Commit Graph

192711 Commits

Author SHA1 Message Date
varga%netscape.com
b87aeb1010 Fix for bug 202477. Closing any browser window causes loooong hang (@ nsBookmarksService::WriteBookmarks).
r=darin, sr=smfr, patch by bsmedberg


git-svn-id: svn://10.0.0.236/trunk@235842 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-12 17:50:47 +00:00
varga%netscape.com
0077a934c0 Follow up fix for bug 199872. Bookmarks service doesn't appear to import IE
favorites
- fixing debug builds
- also changing DEBUG to DEBUG_varga to be less annoying
r=ccarlen


git-svn-id: svn://10.0.0.236/trunk@235841 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-12 17:50:46 +00:00
varga%netscape.com
8b7a7759da Fix for bug 199872. Bookmarks service doesn't appear to import IE favorites.
r=jag, sr=bryner


git-svn-id: svn://10.0.0.236/trunk@235840 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-12 17:50:45 +00:00
varga%netscape.com
e2df9a4f56 Fix for bug 201013. Move bookmarks transaction manager to bookmarks service.
Fixes also bug 199364 and 200771.
r=pch, sr=jag


git-svn-id: svn://10.0.0.236/trunk@235839 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-12 17:50:44 +00:00
varga%netscape.com
b0a0ba1af4 Fix for bug 200498. Multiple copies of my bookmarks file are showing up in TEMP / bookmark changes are lost / cannot modify or delete.
r=bsmedberg, sr=bryner


git-svn-id: svn://10.0.0.236/trunk@235838 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-12 17:50:43 +00:00
varga%netscape.com
837ba310b1 Fix for bug 191783. Convert bookmark implemenation to use nsIFile instead of nsFileSpec.
patch by bsmedberg, r=varga, sr=alecf


git-svn-id: svn://10.0.0.236/trunk@235837 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-12 17:50:42 +00:00
chanial%noos.fr
dfe0f1e9a5 Landing of the bookmarks rewrite TBOOKMARKS_20030320_BRANCH (bug 196756) part one.
It includes:
- bug 160019: Robust bookmarks handling.
- bug 53422: Bookmarks Transaction Manager
- bug 36339: top level bookmark root
- bug 114962: spring loaded bookmark menu in menubar
Thanks to Jan for the great help, bug fixing and testing.

Jan's fixes include:
- bug 51683: unique URI for bookmarks
- bug 99860: new file bookmarks dialog
- bug 121053: optional labels for separators

r=jag, sr=bryner


git-svn-id: svn://10.0.0.236/trunk@235836 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-12 17:50:41 +00:00
bzbarsky%mit.edu
8e65e24bb9 Fix a few leaks, convert to nsCOMArray for mObservers. Bug 198275,
r=varga@netscape.com, sr=alecf


git-svn-id: svn://10.0.0.236/trunk@235835 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-12 17:50:40 +00:00
varga%netscape.com
c0b7832522 Whitespace cleanup for bug 191783.
r=varga, rs=sspitzer, patch by Benjamin Smedberg <bsmedberg@covad.net>


git-svn-id: svn://10.0.0.236/trunk@235834 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-12 17:50:39 +00:00
timeless%mozdev.org
7e459135bd Bug 196834 all bookmarks lost when using "browser.bookmarks.file" pref and switching profile
r=ccarlen sr=alecf


git-svn-id: svn://10.0.0.236/trunk@235833 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-12 17:50:38 +00:00
sfraser%netscape.com
05e1a407b2 Fix bug 195160: remove static NS_DEFINE_IID from header files. r=cls, sr=alecf.
git-svn-id: svn://10.0.0.236/trunk@235832 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-12 17:50:37 +00:00
cbiesinger%web.de
7f283b6642 190020 r=timeless sr=alecf GetResource should take AUTF8String
git-svn-id: svn://10.0.0.236/trunk@235831 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-12 17:50:36 +00:00
varga%netscape.com
e546a77ec6 Fix for bug 182842. major perf regression (O(N^2)) in bookmark writing (closing windows)
r=darin, sr=jag, a=dbaron


git-svn-id: svn://10.0.0.236/trunk@235830 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-12 17:50:35 +00:00
jrgm%netscape.com
b4768c821d remove '#ifndef REPEATING_TIMERS' code. This was accidentally turned back on in 9/02 after being dead from 12/01, and will now revert to using repeating timers. Affect caret, <blink>, bookmarks & search 'ping'. bug 182141, r+sr=smfr
git-svn-id: svn://10.0.0.236/trunk@235829 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-12 17:50:34 +00:00
dbaron%dbaron.org
c24de68b8f Bug 178643: Remove uses of NS_INIT_ISUPPORTS, since it is no longer needed. r=timeless sr=jag
git-svn-id: svn://10.0.0.236/trunk@235828 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-12 17:50:33 +00:00
bzbarsky%mit.edu
87d7274a5a Backing out nisheeth. The orange all over (leak/bloat tests, ports) is his.
a=drivers@mozilla.org speaking through the oracle of blizzard


git-svn-id: svn://10.0.0.236/trunk@235827 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-12 17:50:32 +00:00
nisheeth%netscape.com
c2e20cfaf6 Checkin for bug 182366. r=heikki. sr=hewitt. a=asa. Start of project to use machine learning to better order results shown in the autocomplete dropdown.
git-svn-id: svn://10.0.0.236/trunk@235826 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-12 17:50:31 +00:00
rjc%netscape.com
581bb07dc5 Fix bug # 180423: implement nsIRDFRemoteDataSource::FlushTo() which enables, among other things, serializing bookmarks as RDF. r=pavlov sr=ben
git-svn-id: svn://10.0.0.236/trunk@235825 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-12 17:50:30 +00:00
timeless%mozdev.org
90c72c0766 Bug 174583 Remove nsIRDFDataSource { nsIEnumerator GetAllCommands(in nsIRDFResource aSource); }
r=rjc,bienvenu sr=alecf


git-svn-id: svn://10.0.0.236/trunk@235824 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-12 17:50:29 +00:00
timeless%mozdev.org
4a3e0cc2fd Bug 156814 If bookmark file is symlink, mozilla overwrites symlink with a file
r=caillon sr=bz


git-svn-id: svn://10.0.0.236/trunk@235823 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-12 17:50:28 +00:00
timeless%mozdev.org
ccb90f431d backing out.
git-svn-id: svn://10.0.0.236/trunk@235822 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-12 17:50:27 +00:00
timeless%mozdev.org
d11120d79d Bug 174583 Remove nsIRDFDataSource { nsIEnumerator GetAllCommands(in nsIRDFResource aSource); }
r=rjc,bienvenu sr=alecf


git-svn-id: svn://10.0.0.236/trunk@235821 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-12 17:50:26 +00:00
chanial%noos.fr
071851dfd7 Fix adding a group of tab and bookmark transaction manager horking in phoenix.
Allow the insertion of a resource in a valid container that isn't in the bookmark graph.
Not part of the build


git-svn-id: svn://10.0.0.236/trunk@235820 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-12 17:50:25 +00:00
blakeross%telocity.com
f2f97f12d9 174132 - bookmarks shouldn't hardcode navigator chrome url (fix bookmarks notifications in Phoenix). r=bryner sr=hewitt a=brendan
git-svn-id: svn://10.0.0.236/trunk@235819 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-12 17:50:24 +00:00
blakeross%telocity.com
bb55c44d9e Minor bookmarks tweaks for Phoenix. Not part of build. r/sr=ben
git-svn-id: svn://10.0.0.236/trunk@235818 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-12 17:50:23 +00:00
rjc%netscape.com
bb963e4601 Fix bug # 170622: Bookmarks deletion cmd needs to go through RDF composite db cmd APIs. Bookmarks need to NS_RDF_ASSERTION_REJECTED on unknown nodes. Bookmarking a group of tabs fix. r=blake sr=jag
git-svn-id: svn://10.0.0.236/trunk@235817 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-12 17:50:22 +00:00
darin%netscape.com
35001bd32c fixes bug 157135 "nsIFileURL need to be frozen" r=dougt sr=bzbarsky
git-svn-id: svn://10.0.0.236/trunk@235816 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-12 17:50:21 +00:00
hyatt%netscape.com
e44f1bdfa0 Set an infinite expiration for bookmark favicons. Not used by Mozilla (Phoenix only). r=brendan, sr=jag
git-svn-id: svn://10.0.0.236/trunk@235815 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-12 17:50:20 +00:00
chanial%noos.fr
f98b8feaf8 Bug 167180: new API in nsIBookmarksService for creating a new resource (bookmark, folder, folder group and separator) r/sr=hyatt,blake,bryner moa=ben
git-svn-id: svn://10.0.0.236/trunk@235814 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-12 17:50:19 +00:00
dougt%netscape.com
3e7adefdfd 166917. Clean up xpcom SDK includes. r=rpotts@netscape.com, sr=alecf@netscape.com, a=rjesup@wgate.com
git-svn-id: svn://10.0.0.236/trunk@235813 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-12 17:50:18 +00:00
dougt%netscape.com
3bf215b357 Fixes up the timer interface. b157136, r=rpotts@netscape.com, sr=alecf@netscape.com, a=rjesup@wgate.com
git-svn-id: svn://10.0.0.236/trunk@235812 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-12 17:50:17 +00:00
rjc%netscape.com
e834b2cfec Fix bug # 145858 - imported bookmarked issue with NetPositive. Change required to old bug fix to get search results resolving correctly with aggregation. r=sergei_d@fi.tartu.ee sr=darin
git-svn-id: svn://10.0.0.236/trunk@235811 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-12 17:50:16 +00:00
dougt%netscape.com
f8474f95e3 Move FROZEN ContractID into nsXPCOM.h and define r=rpotts, sr=alec, b=166426
git-svn-id: svn://10.0.0.236/trunk@235810 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-12 17:50:15 +00:00
timeless%mac.com
0bcee9793c Bug 161945 clean up simple mac build warnings
r=dbradley sr=bz


git-svn-id: svn://10.0.0.236/trunk@235809 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-12 17:50:14 +00:00
alecf%netscape.com
c6045b41a6 bug 157624 - freeze nsISupportsPrimitives, which includes changing nsISupport[C]String over to using A[C]String and fixing consumers
r=dougt, sr=darin


git-svn-id: svn://10.0.0.236/trunk@235808 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-12 17:50:13 +00:00
henry.jia%sun.com
ac8abd69cd Fix bug 159889: replace the hardcode of "@mozilla.org/preferences;1" with NS_PREF_CONTRACTID
Patch by leon.zhang@sun.com
r=Henry, sr=alecf


git-svn-id: svn://10.0.0.236/trunk@235807 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-12 17:50:12 +00:00
henry.jia%sun.com
639c45905a 2nd patch for bug 158080
Description: replace the hardcode of "@mozilla.org/embedcomp/window-watcher;1" with NS_WINDOWWATCHER_CONTRACTID
Patch by Henry.Jia@sun.com
r=anto, sr=alecf


git-svn-id: svn://10.0.0.236/trunk@235806 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-12 17:50:11 +00:00
alecf%netscape.com
53ce02351f bug 157624 - prep for freezing nsISupports* primitives by renaming the string classes appropriately
nsISupportsString  -> nsISupportsCString
nsISupportsWString -> nsISupportsString
r=dougt, sr=jag


git-svn-id: svn://10.0.0.236/trunk@235805 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-12 17:50:10 +00:00
kyle.yuan%sun.com
6d5bb8c4a2 Bug 151837 Export Bookmarks in Bookmark Manager saves nothing
r=pierrechanial@netscape.net, sr=blake, a=asa
Must not delete/rename the temp file if tempFile == aBookmarksFile


git-svn-id: svn://10.0.0.236/trunk@235804 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-12 17:50:09 +00:00
cbiesinger%web.de
7a420b764a address reviewer comments (whitespace)
git-svn-id: svn://10.0.0.236/trunk@235803 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-12 17:50:08 +00:00
cbiesinger%web.de
4f176e898f bug 145858 patch by sergei_d@fi.tartu.ee r=timeless a=asa
Imported NetPositive Bookmarks are not loaded properly anymore


git-svn-id: svn://10.0.0.236/trunk@235802 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-12 17:50:07 +00:00
bryner%netscape.com
551888aaa8 Fix all of the warnings about member initializer ordering in constructors (bug 156135). r=timeless, sr=jag.
git-svn-id: svn://10.0.0.236/trunk@235801 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-12 17:50:06 +00:00
ben%netscape.com
8124ed7237 Fix for 86501 - bookmarks truncated when disk full
Make bookmarks check on the success of the file stream write before overwriting the old bookmarks file with the new one.
r=darin, sr=brendan


git-svn-id: svn://10.0.0.236/trunk@235800 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-12 17:50:05 +00:00
cbiesinger%web.de
f44c1bf328 bug 115473 r=pavlov sr=brendan
Remove timer priorities


git-svn-id: svn://10.0.0.236/trunk@235799 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-12 17:50:04 +00:00
timeless%mac.com
78c81ad374 Bug 139471 Rewrite of the personal toolbar drag and drop observer patch=pierrechanial@netscape.net, r=timeless, sr=ben
(maybe you should increment the version number to 2.1)


git-svn-id: svn://10.0.0.236/trunk@235798 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-12 17:50:03 +00:00
ben%netscape.com
2ddbb7814b Fix for bug 86501 - bookmarks.html file is truncated to 0-length when shutting down with a full profile disk. Write bookmarks to a temporary file, and rename that to 'bookmarks.html' only if the write operation succeeded. r=bryner, sr=jag.
git-svn-id: svn://10.0.0.236/trunk@235797 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-12 17:50:02 +00:00
darin%netscape.com
ced9a6355d fixing XP_WIN bookmarks bustage
git-svn-id: svn://10.0.0.236/trunk@235796 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-12 17:50:01 +00:00
jaggernaut%netscape.com
b9cd304258 Bug 129428: Paste doesn't work in bookmark manager. Patch by ben@netscape.com, r=pierrechanial@netscape.net, sr=jag
git-svn-id: svn://10.0.0.236/trunk@235795 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-12 17:50:00 +00:00
darin%netscape.com
ce480db3b2 fixes bug 129279 "nsIFile unicode/utf8/ascii task"
r=dougt sr=alecf


git-svn-id: svn://10.0.0.236/trunk@235794 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-12 17:49:59 +00:00
ben%netscape.com
ecbafae386 Fix two bugs:
- 130614 [adt2] Trunk crashes on startup on Win95 @ nsBookmarksService::ParseFavoritesFolder
         On older Windows installs, IE4 is not present and as a result there's no system
         favorites folder. Insert a null check so that we only parse a system favorites folder
         if one exists.
         r=bryner, sr=hyatt
- 127476 [adt1] Non-ASCII characters in IE Favorites are imported as garbage.
         IE stores Favorite Name as the non-extension part of the file name (baseName). The
         code was using GetFileBaseName, which returns a CString (dumb!). Converted to
         extract the bookmark name from the unicode leaf name.
         r=ftang, sr=hyatt


git-svn-id: svn://10.0.0.236/trunk@235793 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-12 17:49:58 +00:00