1326 Commits

Author SHA1 Message Date
timeless%mac.com
0597ad741b Bug 98080 ask for an attachment number when no params are given
r=dkl r=justdave


git-svn-id: svn://10.0.0.236/trunk@110929 18797224-902f-48f8-a5cc-f745e15eee43
2001-12-20 23:42:28 +00:00
zach%zachlipton.com
78c6d67164 Fix for bug 113646, midair when changing assignee gives error. Fix changes sub trim() in globals.pl not to use $_ so as not to conflict with $_ values allready
set.

Patch by myk@mozilla.org, r1=bbaetz, r2=dave.


git-svn-id: svn://10.0.0.236/trunk@110600 18797224-902f-48f8-a5cc-f745e15eee43
2001-12-17 01:29:52 +00:00
justdave%syndicomm.com
f7d2ddd8f0 Fix for bug 102487: If you had "comment on product change required" turned on in your installation, Bugzilla would warn you of
a forgotten comment AFTER allowing you to choose new components, versions, and milestones, forcing you to hit your back button
TWICE to correct your mistake.  This checkin corrects that.
Patch by David Kilzer <ddkilzer@theracingworld.com>
r= caillon, gerv


git-svn-id: svn://10.0.0.236/trunk@110556 18797224-902f-48f8-a5cc-f745e15eee43
2001-12-16 00:05:54 +00:00
jake%acutex.net
640a455469 Bug 37339 and Bug 80183 - Adding a sidebar.cgi and index.cgi. The sidebar.cgi can currently be used in Mozilla/Netscape 6 and uses XUL that was originally written by Scott Collins <scc@mozilla.org>. The index.cgi displays both the proper header and footer in the appropriate places. It also changes the links accoding to if you are logged in or not.
r= ddk, kiko


git-svn-id: svn://10.0.0.236/trunk@110402 18797224-902f-48f8-a5cc-f745e15eee43
2001-12-12 22:41:19 +00:00
justdave%syndicomm.com
59a509ab6f Fix for bug 73502: midair collision wasn't catching other bugs changing dependencies
Patch by Dave Miller
r= bbaetz, jake


git-svn-id: svn://10.0.0.236/trunk@110194 18797224-902f-48f8-a5cc-f745e15eee43
2001-12-11 02:38:18 +00:00
justdave%syndicomm.com
c6156b2092 Re-fix for bug 102141: The prior checkin on this bug caused an error if you could only see one product and you tried to
change a bug.
Fix by David Kilzer <ddk@theracingworld.com>
r= justdave, bbaetz


git-svn-id: svn://10.0.0.236/trunk@110134 18797224-902f-48f8-a5cc-f745e15eee43
2001-12-09 20:23:31 +00:00
justdave%syndicomm.com
17f6281e23 SECURITY FIX bug 54901: If you were using LDAP authentication it would let you log in as anyone if you left the password
blank.
Patch by David Crowe <crow@waveset.com>
r= jmrobins, justdave


git-svn-id: svn://10.0.0.236/trunk@110128 18797224-902f-48f8-a5cc-f745e15eee43
2001-12-09 15:56:23 +00:00
jake%acutex.net
e0604e6a44 Get the file list of files to scan for templates from Support::Files instead of glob('*')
git-svn-id: svn://10.0.0.236/trunk@109381 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-30 21:49:47 +00:00
jake%acutex.net
acaebc81a5 Bug 108312 - The mid-air collision page was only showing the most recent changes if two people comitted changes to a bug while you were viewing it.
r=louie, myk


git-svn-id: svn://10.0.0.236/trunk@109001 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-27 15:04:52 +00:00
myk%mozilla.org
81302cc7d8 Fix for bug 109802: Make it clear how to enter mysql passwords with special characters into localconfig.
Patch by Dave Miller <justdave@syndicomm.com>.
r=ddkilzer,louie.


git-svn-id: svn://10.0.0.236/trunk@108949 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-27 00:49:26 +00:00
myk%mozilla.org
61c2e2550c Fix for bug 101875: Put the product column before the component column rather than after.
Patch by Paul Baker <pbaker@where2getit.com>.
Low risk, r=myk, no second review needed.


git-svn-id: svn://10.0.0.236/trunk@108939 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-26 23:29:29 +00:00
jake%acutex.net
57dc03667d Bug 109530 - xml.cgi was quoting stuff way too much. This is because it was incorrectly quoted in Bug.pm
r= justdave, louie


git-svn-id: svn://10.0.0.236/trunk@108898 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-26 14:16:10 +00:00
justdave%syndicomm.com
fe649f9b61 Fix for bug 61634: explain what "Milestone URL" is on the editproducts page.
patch by Matthew Tuck <matty@chariot.net.au>
r= caillon, justdave


git-svn-id: svn://10.0.0.236/trunk@108805 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-22 15:46:27 +00:00
gerv%gerv.net
401144e72a Bug 104261 - incorrect template paths. r=myk, ddk.
git-svn-id: svn://10.0.0.236/trunk@108799 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-22 06:12:36 +00:00
justdave%syndicomm.com
a159436d81 Fix for bug 99864: consistant use of "product" vs "program"
Patch by Josh Soref <timeless@mac.com>
r= dkl, justdave


git-svn-id: svn://10.0.0.236/trunk@108715 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-21 19:56:28 +00:00
timeless%mac.com
7560074afe Bugzilla Bug 93754 describe should be #directable
r=justdave,dkl


git-svn-id: svn://10.0.0.236/trunk@108705 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-21 16:44:38 +00:00
justdave%syndicomm.com
e0e98de5e0 Fix for bug 102141: SECURITY FIX - the Product popup menu on the show_bug form listed all products, even if the user didn't
have access to all of them.  It now only shows products the user has access to (and the product the bug is in, if the user is
viewing it because of some other override)
Patch by George Hotelling <george.hotelling@iconideas.com> and Dave Miller <justdave@syndicomm.com>
r= bbaetz, caillon


git-svn-id: svn://10.0.0.236/trunk@108680 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-21 08:31:59 +00:00
matty%chariot.net.au
92a2b2029a Bug 110276:SQL error in globals.pl.
Patch by me, r=bbaetz,caillon.


git-svn-id: svn://10.0.0.236/trunk@108678 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-21 08:09:32 +00:00
barnboy%trilobyte.net
66a77561a4 Added blurb about unified diffs.
git-svn-id: svn://10.0.0.236/trunk@108621 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-20 20:16:24 +00:00
barnboy%trilobyte.net
9cd514d2f1 Taint mode note.
git-svn-id: svn://10.0.0.236/trunk@108617 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-20 20:11:41 +00:00
barnboy%trilobyte.net
7b8146183a Added Javascript, Cookies, and Templatization requirements to Hacking
Bugzilla.


git-svn-id: svn://10.0.0.236/trunk@108616 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-20 20:09:06 +00:00
barnboy%trilobyte.net
8c2295b971 Added tip about checking sanitycheck.cgi if you make schema changes,
per bug 98049.


git-svn-id: svn://10.0.0.236/trunk@108613 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-20 19:56:31 +00:00
barnboy%trilobyte.net
5c12496ebe Removed references to bugzilla.mozilla.org so we can avoid
spurious bug postings.  However, this file will need some significant
treatment for 2.16 release since the query.cgi interface has changed.


git-svn-id: svn://10.0.0.236/trunk@108595 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-20 18:22:30 +00:00
justdave%syndicomm.com
b1524a2399 Backing out previous checkin, this file is distributed with Bugzilla, we don't need mozilla-specific information in it.
git-svn-id: svn://10.0.0.236/trunk@108594 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-20 18:11:05 +00:00
barnboy%trilobyte.net
f3a9f9a24c Added one liner mentioning that mozilla.org provides only one vote
per bug.


git-svn-id: svn://10.0.0.236/trunk@108591 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-20 17:46:14 +00:00
barnboy%trilobyte.net
93afffd7ff Modified Win32 notes regarding system() calls per bug 99595.
git-svn-id: svn://10.0.0.236/trunk@108590 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-20 17:26:45 +00:00
barnboy%trilobyte.net
64144297d3 Fixed CPAN locations per bug 97582.
git-svn-id: svn://10.0.0.236/trunk@108589 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-20 17:18:03 +00:00
barnboy%trilobyte.net
a0d50fc6a0 Added bit about needing proper <Directory> permissions in order
for .htaccess to function.  See bug 97668.


git-svn-id: svn://10.0.0.236/trunk@108588 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-20 17:09:38 +00:00
barnboy%trilobyte.net
aa0ea6b3f9 Changed openjade compilation instructions to match new commands
required by XML conversion of the Guide.


git-svn-id: svn://10.0.0.236/trunk@108586 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-20 16:41:23 +00:00
barnboy%trilobyte.net
2049c9f6b5 Initial conversion to XML format from SGML.
Note this is a work-in-progress.  It compiles cleanly, but I am not yet
submitting compiled HTML and text.
There is one notable problem: nsgmls barfs on the <imagedata> tag in
database.sgml during validation.  openjade handles it fine. Weird.


git-svn-id: svn://10.0.0.236/trunk@108585 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-20 16:36:28 +00:00
myk%mozilla.org
cb97f8190d Fix for bug 109240: fixes the regression that changed the way comments regarding attachment creation are formatted.
Patch by Jake <jake@acutex.net>.
r=myk@mozilla.org, no second review needed.


git-svn-id: svn://10.0.0.236/trunk@108542 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-20 02:59:55 +00:00
zach%zachlipton.com
a8d489f851 Fix for bug 107120, templates/default/global/header has invalid HTML.
Patch removes a <meta> tag as per bug 38856.

Patch by David D. Kilzer <mailto:ddkilzer@theracingworld.com>.
r1=Christopher Aillon <mailto:caillon@returnzero.com>. No 2nd review
required as per caillon.


git-svn-id: svn://10.0.0.236/trunk@108525 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-20 01:59:57 +00:00
gerv%gerv.net
f2a3c7158a Bug 98707. Query.cgi rewrite. Patch by me, layout by mpt and others, r=justdave, mattyt. Wahey!
git-svn-id: svn://10.0.0.236/trunk@108457 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-18 22:23:31 +00:00
gerv%gerv.net
34838abe95 Bug 98707. Query.cgi rewrite, reformatting and templatisation. Patch by me, layout by mpt and others, r=justdave,matty. Wahey!
git-svn-id: svn://10.0.0.236/trunk@108455 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-18 22:20:20 +00:00
matty%chariot.net.au
ca6d7f14fc Moving a comment to the right place, in order to be able to make a comment about my previous check in that accidentally got checked in without a comment, and hence didn't show up on Tinderbox I think.
It was a change to CGI.pl, a fix for bug 105812: Rename "Components" link in sub GetCommandMenu() to "Products".

The patch was by James A Laska <jlaska@us.ibm.com>.


git-svn-id: svn://10.0.0.236/trunk@108420 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-18 03:54:54 +00:00
matty%chariot.net.au
067fbac069 *** empty log message ***
git-svn-id: svn://10.0.0.236/trunk@108419 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-18 03:22:50 +00:00
justdave%syndicomm.com
bfa6922bde Fix for bug 100788: enter_bug.cgi wasn't correctly interpretting whether or not a partial URL needed an http:// added to the
front of it, which had the side-effect of duplicating the http:// on the front when a URL was passed from Bugzilla Helper.
Patch by Josh Soref <timeless@mac.com>
r= justdave, caillon


git-svn-id: svn://10.0.0.236/trunk@108404 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-17 23:05:48 +00:00
justdave%syndicomm.com
f7a62b41f9 Fix for bug 109354: After entering a new bug, the link offering to add an attachment to the bug you just created pointed at
the old attachment form instead of the new one.
Patch by Josh Soref <timeless@mac.com>
r= myk x2


git-svn-id: svn://10.0.0.236/trunk@108402 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-17 22:40:02 +00:00
justdave%syndicomm.com
b696d2648c Fix for bug 107120: templates/default/global/header was generating HTML that wouldn't validate as HTML 4.01 Transitional
Patch by Dave Miller <justdave@syndicomm.com>
r= jake, bbaetz


git-svn-id: svn://10.0.0.236/trunk@108401 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-17 22:25:15 +00:00
justdave%syndicomm.com
1a5671d3ab Fix for bug 92500: line-feeds were not being properly converted when submitting parameter changes with some Mac browsers.
Patch by Gervase Markham <gerv@mozilla.org>
r= ddk, justdave


git-svn-id: svn://10.0.0.236/trunk@108399 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-17 22:18:07 +00:00
justdave%syndicomm.com
ab0ed93ca8 Backing out previous checkin, it broke the tree. :(
git-svn-id: svn://10.0.0.236/trunk@108396 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-17 21:28:24 +00:00
justdave%syndicomm.com
2f07aa0c10 Fix for bug 102487: If admin has set preferences to require a comment on a product/component change, prompt the user that they
forgot to comment first, before prompting for component, milestone, and version for new product.
Patch by Garvase Markham <gerv@mozilla.org>
r= kiko, ddk


git-svn-id: svn://10.0.0.236/trunk@108394 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-17 21:12:53 +00:00
justdave%syndicomm.com
38ae4f7251 Fix for bug 12284: allow user to specify which columns to display in a bug list
Patch by Andreas Franke <afranke@ags.uni-sb.de>
r= gerv, kiko


git-svn-id: svn://10.0.0.236/trunk@108392 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-17 21:04:37 +00:00
zach%zachlipton.com
0d8c3fd7a1 Fix the double testing of .pm files.
No review needed for tests at this time.


git-svn-id: svn://10.0.0.236/trunk@108382 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-17 17:29:06 +00:00
matty%chariot.net.au
2ddf8be3ca Bug 104677 : Votes field (text style) on showvotes.cgi defaults to size 5, not natural size and doesn't include a maxlength attribute.
Patch by Christoper Aillon <caillon@returnzero.com>.


git-svn-id: svn://10.0.0.236/trunk@108373 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-17 10:29:55 +00:00
bbaetz%cs.mcgill.ca
eb246d5306 Bug 101560, pt 2. Perl 5.00503 gives a (bogus?) warning which 5.6 doesn't.
Quote manually rather than using qw to get arround this


git-svn-id: svn://10.0.0.236/trunk@108365 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-17 07:57:25 +00:00
bbaetz%cs.mcgill.ca
3bc2957b7a Bug 101560 - clear some more env vars so that system calls will run in
taint mode. The perforce integration stuff needs this.

r=gerv,mattyt


git-svn-id: svn://10.0.0.236/trunk@108362 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-17 07:19:46 +00:00
gerv%gerv.net
52ebafa034 Bug 6419 - command-line query tools by Andreas Franke <afranke@ags.uni-sb.de>.
git-svn-id: svn://10.0.0.236/trunk@108177 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-15 17:04:58 +00:00
bbaetz%cs.mcgill.ca
9ca8a3c375 Bug 107718 pt 2 - use subtraction instead of the ~ operator, which older
mysql versions don't support. Remove the checksetup.pl restriction, too.

r=jake x2


git-svn-id: svn://10.0.0.236/trunk@108061 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-14 15:12:23 +00:00
jake%acutex.net
ff3e46489b We don't really need to look for fragments that are pulled in by [% INCLUDE %] or [% PROCESS %]. While removing this code bit doesn't allow us to seperatly check that those fragments exist and compile, they'll be checked atomatically when the the template that wants them is run through the process() routine by the 004template.t test. This issue was raised because bug 98707 introduced a [% BLOCK %] element and the syntax for using that is the same as for including a template fragment.
git-svn-id: svn://10.0.0.236/trunk@108008 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-14 03:44:07 +00:00