1326 Commits

Author SHA1 Message Date
gerv%gerv.net
8891347238 Fix license headers and make attachment changed page look like bug changed page. Bug 99518 and 98110. r-myk, no second review.
git-svn-id: svn://10.0.0.236/trunk@107963 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-13 17:24:24 +00:00
jake%acutex.net
9b3a845780 Fix for bug 86300 - If a bug didn't exist and GetBugLink() tried to create a tooltip for it, you'd get uninitialized variables warnings in your error log. This path also introduces a cache so if the same bug # is mentioned more than once during the same running of the script, it only has to query the database once.
r= mattyt, gerv


git-svn-id: svn://10.0.0.236/trunk@107921 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-12 13:43:59 +00:00
bbaetz%cs.mcgill.ca
58006fb10f Oops. Bug 109690 again, r=justdave, gerv
git-svn-id: svn://10.0.0.236/trunk@107916 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-12 05:47:24 +00:00
bbaetz%cs.mcgill.ca
c2a13c0ac1 Bug 109690: Check $bug before using it.
r=justdave,gerv


git-svn-id: svn://10.0.0.236/trunk@107915 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-12 05:39:14 +00:00
timeless%mac.com
01aa33c91c Bugzilla Bug 109138 platform detection not working on macintosh
r=bbaetz,dkl


git-svn-id: svn://10.0.0.236/trunk@107728 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-09 05:32:43 +00:00
myk%mozilla.org
94f803c2c3 Fix for bug 109048: fixes error when creating attachments without logging in.
Patch by Myk Melez <myk@mozilla.org>.
r=bbaetz,gerv


git-svn-id: svn://10.0.0.236/trunk@107716 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-09 01:11:09 +00:00
justdave%syndicomm.com
e78b6416c2 Fix for bug 99519: timestamps were not being set correctly in the activity table in some situations, and the delta_ts on the
bug itself was not always being updated if dependencies or CCs changed.
Patch by Dave Miller <justdave@syndicomm.com>
r= bbaetz, jake


git-svn-id: svn://10.0.0.236/trunk@107644 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-08 03:38:12 +00:00
myk%mozilla.org
3b483d8209 Fix for bug 104652: Duplicate bugs in the dependency tree now get marked with the message "This bug appears elsewhere in this tree." so users know why the bug does not appear to have dependencies.
Patch by Gerv <gerv@mozilla.org>.
r=jake@acutex.net,myk@mozilla.org


git-svn-id: svn://10.0.0.236/trunk@107640 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-08 02:43:55 +00:00
myk%mozilla.org
f128dfb46b Fix for bug 108822: Prevent any user from changing their own groupset.
Patch by Jake <jake@acutex.net>.
r=bbaetz,myk


git-svn-id: svn://10.0.0.236/trunk@107633 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-08 00:54:15 +00:00
myk%mozilla.org
37c1fa29af Fix for bug 108821: Prevent users with any blessgroupset privileges from blessing any group set.
Patch by Jake <jake@acutex.net> and Bradley <bbaetz@cs.mcgill.ca>.
r=jake,myk for Bradley's portion, r=bbaetz,myk for Jake's portion.


git-svn-id: svn://10.0.0.236/trunk@107632 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-08 00:52:13 +00:00
myk%mozilla.org
f0967cda10 Fix for bug 108812: Prevent users from running queries containing arbitrary SQL.
Patch by Jake <jake@acutex.net>
r=bbaetz,myk


git-svn-id: svn://10.0.0.236/trunk@107631 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-08 00:49:18 +00:00
bbaetz%cs.mcgill.ca
8904a09db5 Require (temporarily) mysql >= 3.23.5 for the ~ operator, needed for the
fix to bug 107718. This should be removed when the group stuff lands (bug
60822).

r=justdave x 2


git-svn-id: svn://10.0.0.236/trunk@107624 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-07 22:42:32 +00:00
bbaetz%cs.mcgill.ca
9caaabcc10 Bug 101166 - users seeing a bug via _accessible bits should see that its
the group

r=justdave,jake


git-svn-id: svn://10.0.0.236/trunk@107605 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-07 16:11:33 +00:00
jake%acutex.net
7a6b9817cc Bug 108547 - Make the JavaScript use proper DOM
Patch by Christopher Aillon <caillon@returnzero.com>
r= timeless@bemail.org, kiko@async.com.br


git-svn-id: svn://10.0.0.236/trunk@107604 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-07 14:58:56 +00:00
jake%acutex.net
b4c2275ed0 Refixing bug 71840 - The name should be the 'name' should be the same as what the 'href' points it too...
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@107468 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-06 18:06:02 +00:00
justdave%syndicomm.com
2d28f97361 SECURITY FIX see bug 108385: Due to trusting of passed form fields that shouldn't have been trusted, it was possible to add a comment to a bug pretending to be someone else if you edited the HTML by hand before submitting. The bug form did not include the field in question, but due to legacy processing code, the field was still trusted if it was present.
Patch by Dave Miller <justdave@syndicomm.com>
r= jake x2


git-svn-id: svn://10.0.0.236/trunk@107350 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-05 20:47:17 +00:00
justdave%syndicomm.com
2218691609 SECURITY FIX see bug 108516: Due to trusting of passed form fields that shouldn't have been trusted, it was possible to file a
bug pretending to be someone else if you edited the HTML by hand before submitting.
Patch by Dave Miller <justdave@syndicomm.com>
r= bbaetz, jake


git-svn-id: svn://10.0.0.236/trunk@107349 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-05 20:43:35 +00:00
timeless%mac.com
b2399744c5 Bugzilla Bug 107672 Browser OS/Platform discrimination alg sucks
r=bbaetz, jake
Windows XP references are #'d because of bug 92763


git-svn-id: svn://10.0.0.236/trunk@107311 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-05 04:44:34 +00:00
bbaetz%cs.mcgill.ca
b2918e050d Bug 107718 - mass changes give all changed bugs the groupset of the first
bug in the list.

Do bit fiddling instead of adding groupsets from the first bug.

r=justdave, jake


git-svn-id: svn://10.0.0.236/trunk@107224 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-03 05:49:23 +00:00
justdave%syndicomm.com
4aaa66afe8 Fix for bug 105773: Email addresses in the CC list are now sorted case-insensitively
Patch by Adam Kennedy <bugzilla@ali.as>
r= justdave x2


git-svn-id: svn://10.0.0.236/trunk@107178 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-03 02:05:43 +00:00
justdave%syndicomm.com
a0a44f7175 Fix for bug 95615: cosmetic change to clarify error message when trying to use too many votes
Patch by Adam Kennedy <bugzilla@ali.as>
r= justdave x2


git-svn-id: svn://10.0.0.236/trunk@107115 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-02 20:05:13 +00:00
jake%acutex.net
066f569e09 Fixing tinderbox bustage (removing <Tab>s and adding a "use vars" line)
git-svn-id: svn://10.0.0.236/trunk@106800 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-31 03:31:00 +00:00
zach%zachlipton.com
a96de0e001 Have the tests test .pm files as well, yes this creates bustage, this is
intentional!

No review needed for tests at this time.


git-svn-id: svn://10.0.0.236/trunk@106772 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-31 01:06:31 +00:00
myk%mozilla.org
b5c6611091 Fix test bustage by removing tabs.
git-svn-id: svn://10.0.0.236/trunk@106762 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-31 00:21:28 +00:00
myk%mozilla.org
dc4c583cd4 Fix for bug 98602: re-implementation of "create attachment" page.
Patch by Myk Melez <myk@mozilla.org>.
r=gerv@mozilla.org,jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@106739 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-30 23:42:22 +00:00
zach%zachlipton.com
87b667ee3b Fix for bug 96675: checksetup should require admin e-mail address satisfy emailregexp. This fix has
checksetup.pl use the emailregexp set in params if the params file exists, or ensures that it matches the
default emailregexp from defparams.pl.

r1=justdave, r2=bbaetz.


git-svn-id: svn://10.0.0.236/trunk@106499 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-28 03:40:59 +00:00
jake%acutex.net
be3ee559e5 A few enhancements to the template test:
* If there's a compilation error, report what it is
 * Don't try to compile a template if it doesn't exist
   - We already tested for that and issued an ERROR
 * Define the 'url' FILTER


git-svn-id: svn://10.0.0.236/trunk@106481 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-27 15:27:31 +00:00
jake%acutex.net
d377a74d28 Bug 105879 - Footer links have an extra | by Sanity Check
Patch by Matthew Tuck <matty@chariot.net.au>
r= dkl@redhat.com, jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@106377 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-26 18:49:33 +00:00
jake%acutex.net
6786208022 Bug 81594 - SQL error after editing user entry when changing numerous things at once (including the login name).
Patch by Matthew Tuck <matty@chariot.net.au>
r= dkl@redhat.com, jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@106375 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-26 18:35:04 +00:00
jake%acutex.net
e8bbc7ef2a Check templates for tabs, also.
git-svn-id: svn://10.0.0.236/trunk@106358 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-26 13:21:38 +00:00
myk%mozilla.org
becbccb87b Fix for bug 98602: re-implementation of "create attachment" page.
Patch by Myk Melez <myk@mozilla.org>.
r=gerv@mozilla.org,jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@106281 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-25 20:37:53 +00:00
jake%acutex.net
e6f2627084 Bug 104065 - Stop uninitilized string warnings from getting into the error log when the login cookie doesn't exist.
Patch by Dave Miller <justdave@syndicomm.com>
r= gerv@mozilla.org, jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@106273 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-25 14:46:58 +00:00
bbaetz%cs.mcgill.ca
59af65fd2f Fixed "used only once" warning coming from my patch for bug 97469. The
warning was hidden from the tests by bug 106424.

r=Jake, no 2nd review needed.


git-svn-id: svn://10.0.0.236/trunk@106195 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-24 20:33:49 +00:00
jake%acutex.net
f6426c6f03 Don't rely on the TEST_VERBOSE environment variable (no longer exported from runtests.sh) and instead print to the TESTOUT file handle pulled in from Test::More. This will allow the testing backend to check for verbosity rather than having to handle it in the .t files.
git-svn-id: svn://10.0.0.236/trunk@106182 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-24 18:41:53 +00:00
jake%acutex.net
5f73a3f4db Bug 106424 - We weren't going orange on warnings such as "used only once". This script now properly outputs the --WARNING and fails on such a condition.
git-svn-id: svn://10.0.0.236/trunk@106166 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-24 13:29:49 +00:00
myk%mozilla.org
90cb92a74d Fix for bug 106315: Link on bug list for emailing QA contacts.
Patch by Dave Miller <justdave@syndicomm.com>.
r=myk@mozilla.org, no second review needed.


git-svn-id: svn://10.0.0.236/trunk@106119 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-24 01:31:09 +00:00
bbaetz%cs.mcgill.ca
cced8d8047 Bug 97469 - Assignee/QA/Reporter/CC don't get email on restricted bugs.
Also fixes seeing bugs in the buglist (bug 95024), dependancy lists,
tooltips, duplicates, and everywhere else I could see which checked group
bugs.groupset == 0.

Also fxed bug 101560, by clearing BASH_ENV

r=myk,justdave


git-svn-id: svn://10.0.0.236/trunk@106051 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-23 15:44:53 +00:00
jake%acutex.net
251ac470d6 Bug 63249 - The Bug Counts report was running very slowly due to unneeded fields/joins in the SQL query.
Patch by Matthew Tuck <matty@chariot.net.au>
r= gerv@mozilla.org, jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@106049 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-23 14:45:45 +00:00
jake%acutex.net
6556ad04b0 Bug 71840 - Make comments referenceable using a #c4 to get the fourth comment.
Patch by Gerv <gerv@mozilla.org> and Myself.
r= jake@acutex.net, gerv@mozilla.org, justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@105883 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-20 13:03:14 +00:00
jake%acutex.net
5fcb9d6a75 Backing out previous change, the wrong patch got checked in.
git-svn-id: svn://10.0.0.236/trunk@105882 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-20 12:59:57 +00:00
gerv%gerv.net
ffb874519d Bug 71840 - make comments referenceable. Patch by gerv/jake. r=justdave, jake/gerv.
git-svn-id: svn://10.0.0.236/trunk@105863 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-20 01:06:59 +00:00
jake%acutex.net
71b60e4071 Bug 105480 - Use the friendly name from the fielddefs table when reporting strictvalue errors if it's available.
Patch by James A. Laska <jlaska@us.ibm.com>
r= justdave@syndicomm.com, jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@105860 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-20 00:50:27 +00:00
jake%acutex.net
d3926a124b Bug 104340 - Changing the UI of the toolbar for hiding bugs in the dependency tree.
Patch by Christian Reis <kiko@async.com.br>
r= justdave@syndicomm.com, gerv@mozilla.org


git-svn-id: svn://10.0.0.236/trunk@105858 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-20 00:22:52 +00:00
jake%acutex.net
692e3604f8 Bug 73180 - We now put a notice at the top of the versioncache file saying that it should not be edited.
Patch by Matthew Tuck <matty@chariot.net.au>
r= gerv@mozilla.org, jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@105856 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-19 23:49:37 +00:00
jake%acutex.net
457d72aeff Bug 103664 - Tests should "use strict;" and not contain any tabs. We should also use the TEST_VERBOSE environment variable instead of VERBOSE.
Patch by David D. Kilzer <ddkilzer@theracingworld.com>
Additional edits by myself to add the emacs mode line.  Also, the change to runtests.sh was done by me.


git-svn-id: svn://10.0.0.236/trunk@105842 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-19 22:39:51 +00:00
jake%acutex.net
eec9d51c7c Fix for bug 105365 - Hacker's Guide should be in SGML. This will make it easier to do other additions to the hacker's guide.
git-svn-id: svn://10.0.0.236/trunk@105776 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-19 16:18:10 +00:00
justdave%syndicomm.com
faaffb8eec yet another meaningless whitespace change to test tinderbox with
git-svn-id: svn://10.0.0.236/trunk@105767 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-19 13:03:52 +00:00
justdave%syndicomm.com
ed3ed56299 another useless whitespace change to test tinderbox with
git-svn-id: svn://10.0.0.236/trunk@105758 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-19 06:19:52 +00:00
justdave%syndicomm.com
ad30940b5e whitespace change to test tinderbox again.
git-svn-id: svn://10.0.0.236/trunk@105754 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-19 05:33:23 +00:00
justdave%syndicomm.com
d8d8ecf9f8 whitespace change to do a test checkin to see how tinderbox reacts
git-svn-id: svn://10.0.0.236/trunk@105750 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-19 04:36:19 +00:00