Commit Graph

3085 Commits

Author SHA1 Message Date
jake%acutex.net
8e42d674c4 Give a logical error message if no products are available to a user for bug entry (bug 84285).
Patch by Paul Thomas <paul.thomas@sse.ie>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@96712 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-08 13:12:13 +00:00
justdave%syndicomm.com
2a73def3a6 Hopefully the fix for bug 77778: component lists, etc stuttering due to corruption in data/versioncache.
Patch design by Terry Weissman <terry@mozilla.org>
Patch implemented by Dave Miller <justdave@syndicomm.com>
r= tara@tequilarista.org


git-svn-id: svn://10.0.0.236/trunk@96651 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-07 21:26:49 +00:00
justdave%syndicomm.com
62f8abbb9a Fix for bug 15980: Password is no longer shown in the location bar on the first page you load after logging in.
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@96648 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-07 20:26:40 +00:00
justdave%syndicomm.com
5c9e4da69d fix typo
git-svn-id: svn://10.0.0.236/trunk@96598 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-07 01:31:51 +00:00
justdave%syndicomm.com
70301d4eb1 Fix "used only once" error, per tinderbox build log.
git-svn-id: svn://10.0.0.236/trunk@96563 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-06 23:09:54 +00:00
justdave%syndicomm.com
0d88c2a487 Fix for bug 21253: removing all single-parameter system() calls from Bugzilla
Patch by Dave Miller <justdave@syndicomm.com>
r= tara@tequilarista.org


git-svn-id: svn://10.0.0.236/trunk@96556 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-06 21:17:42 +00:00
justdave%syndicomm.com
ca7f7346ea Fix for bug 83872: Bugzilla no longer requires the Mysql Perl module, but the DBD::mysql Perl module, and has been this way for a while. Fixing the version checks in checksetup.pl to check the correct module. Also eliminates a DBD::mysql-specific database function call that is depricated in the current version of DBD_mysql.
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net, tara@tequilarista.org


git-svn-id: svn://10.0.0.236/trunk@96555 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-06 21:10:47 +00:00
jake%acutex.net
cceefc3d43 Users should only be able to view attachments if they can view the bug that the file is attached to (bug 70189)
r=tara


git-svn-id: svn://10.0.0.236/trunk@96543 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-06 18:36:25 +00:00
jake%acutex.net
3cb4dd4427 Fixing typo. Attachments isn't spelled 'Attachemnts' (bug 84295).
git-svn-id: svn://10.0.0.236/trunk@96532 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-06 14:25:18 +00:00
justdave%syndicomm.com
4bc7340572 Fix for bug 39557: doeditvotes.cgi will no longer create a vote record for a nonexistant bug if the HTML is tampered with or other bugs cause bad bug numbers in the submitted form.
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@96496 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-06 04:51:55 +00:00
justdave%syndicomm.com
9e1f7b46e4 Fix for bug 82781: describecomponents.cgi now checks viewing permissions to make sure you can see a product
Patch by Myk Melez <myk@mozilla.org>
r= tara@tequilarista.org


git-svn-id: svn://10.0.0.236/trunk@96493 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-06 04:32:45 +00:00
justdave%syndicomm.com
ebc34ab007 Fix for bug 28458: "NEW" bugs were not getting CC or QA Contact information displayed.
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@96491 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-06 04:28:52 +00:00
justdave%syndicomm.com
8928aa2555 Fix for bug 75482: adding the capability to deactivate a group without deleting it (prevent new bugs from being placed into that group, but don't remove the group restriction from bugs already in it).
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@96488 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-06 03:16:52 +00:00
ian%hixie.ch
c39644bda6 * Improved the helpfulness of the extremely verbose debugging information of PLIF.pm by quoting embedded variables
* Implemented MagicCollectingArray, which acts like MagicPipingArray except that the result is collected into one big array instead of multiple arrayrefs
* Added the relevant getCollecting*List methods to the Controller class
* Added DESTROY methods to the magic array to prevent DESTROY method calls from being propagated
* Made the debug.dumpVars string more robust when the data hash includes one of the three magic characters '(', '.' or ')'
* Implemented sanitation in COSES so that any keys in the data hash containing one of the three magic characters '(', '.' or ')' will have them transliterated to '[', ':' and ']' respectively (sanitation is optional and can be bypassed)
* Changed the API of the generic output module's 'output' method to take the optional $session argument last, thus simplifying the call sites a lot
* Implemented the 'dispatcher.output' service in several classes to return strings that must be support in variants (required for a good UI in the COSES editor)
* Renamed the Login module's strings so that they use the dot-notation separating significant parts


git-svn-id: svn://10.0.0.236/trunk@96296 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-04 06:13:22 +00:00
ian%hixie.ch
31afdd6c43 Stub implementation of a COSES editor component, plus added 'component.nameOfComponent' to the list of services provided by the other two components
git-svn-id: svn://10.0.0.236/trunk@96279 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-03 23:06:09 +00:00
ian%hixie.ch
a4e5deac24 Moved AdminCommands.pm and Login.pm to a Component directory
git-svn-id: svn://10.0.0.236/trunk@96278 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-03 22:45:37 +00:00
ian%hixie.ch
c77a5c18e0 Minor bug fixes required to make the code run without crashing...
git-svn-id: svn://10.0.0.236/trunk@96276 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-03 16:14:41 +00:00
ian%hixie.ch
c054620213 Some more minor corrections to get it to run as well as compile... (removes some XXX comments and adds some error checking)
git-svn-id: svn://10.0.0.236/trunk@96275 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-03 15:27:16 +00:00
ian%hixie.ch
e283e3f98d Fixing a gazillion syntax, logic and XML errors and adding some debug code. It compiles!
git-svn-id: svn://10.0.0.236/trunk@96274 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-03 14:49:41 +00:00
ian%hixie.ch
1c4b9ea728 * Added some comments (including some XXX comments where I realised we had missing code)
* Added implicit data to the hash passed to the string expander from the generic output service
* To support the implicit data, added a |hash| stub method to the Session.pm module (and changed the already implemented version in the descendant user service to take this into account)
* To support the implicit data, added |hash| and |getArguments| methods to the Input.pm module (and implemented |getArguments| in the Arguments.pm module)
* To support the implicit data, made the Program.pm module keep track of the executing command
* To support the implicit data, added |hash| and |name| methods to the Program.pm module (actually, |name| was already assumed to exist in other parts of the codebase)
* Corrected trivial semantic mistake in Program.pm's |verifyInput| method
* Added a way to get a user not by username but by a specific address (modifies the user service and the user data source and it's MySQL implementation)
* Implemented GenericOutputs.pm, an implementation of 'dispatcher.output.generic' and 'dataSource.strings.default' for some strings used by other parts of PLIF (currently only supports 'stdout' and 'http' protocols, and minimally at that)
* Implemented Login.pm, a helper module that implements user authentication, user creation and the sending of a new password if it is forgotten, a utility method |hasRight| to ensure that the authenticated user has a particular right (resulting in a message if not), and various routines to support all this.


git-svn-id: svn://10.0.0.236/trunk@96268 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-03 10:11:58 +00:00
tara%tequilarista.org
cbb24b9172 Landing Myk's patch for bug #71767
git-svn-id: svn://10.0.0.236/trunk@96243 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-02 22:02:02 +00:00
jake%acutex.net
f76024a6dd sanitycheck.cgi was able to be run by anybody - even people without Bugzilla accounts. It is now restricted to only people with the editbugs permission (bug 54556).
Patch by Myk Melez <myk@mozilla.org>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@96240 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-02 14:24:45 +00:00
justdave%syndicomm.com
f8543b2ba4 Fix for bug 65190: add comparison type "all words as substrings" and "any words as substrings" to the text fields in query.cgi
Patch by Andreas Franke <afranke@ags.uni-sb.de>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@96226 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-02 04:02:13 +00:00
justdave%syndicomm.com
21860cdbe4 Fix for bug 78407: extra safeguard against overpopping the email list when pruning people who aren't supposed to get mail.
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@96224 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-02 03:19:26 +00:00
justdave%syndicomm.com
c0b8428705 Fix for bug 83596: optional dependency on XML::Parser now checked in checksetup.pl
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@96214 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-02 01:57:22 +00:00
justdave%syndicomm.com
9018fe3035 Fix for bug 83618: checksetup.pl crashes if DBI module isn't already installed.
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@96211 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-02 01:53:01 +00:00
jake%acutex.net
8401f362a9 More leak pluggin. This one fixes bug 39526.
Patch by Myk Melez <myk@mozilla.org>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@96180 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-01 13:38:01 +00:00
justdave%syndicomm.com
603852acc2 Fix for bug 83633: perl warnings in 5.6
r= Hixie


git-svn-id: svn://10.0.0.236/trunk@96174 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-01 10:03:52 +00:00
justdave%syndicomm.com
581eaee916 Fix for bug 73249: perl warnings under 5.6.0.
Patch by Chris Yeh <Chris.Yeh@nokia.com>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@96172 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-01 08:34:45 +00:00
justdave%syndicomm.com
ac828bb8f0 Fix for bug 79317: dependency on CGI::Carp not caught by checksetup.pl
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@96166 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-01 03:13:28 +00:00
justdave%syndicomm.com
0ed9a380b7 backing out previous fix to importxml.pl. It fixed it on Perl 5.6 and broke it on Perl 5.005. Will need to investigate.
git-svn-id: svn://10.0.0.236/trunk@96165 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-01 02:27:52 +00:00
justdave%syndicomm.com
f693a23060 Fix for bug 72862: fixes more Perl warnings in RelationSet.pm and globals.pl
git-svn-id: svn://10.0.0.236/trunk@96164 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-01 02:14:23 +00:00
justdave%syndicomm.com
fc2f6bb5a8 Fix for bug 57848, perl warnings in several files.
Patch by Nick Hibma <n_hibma@qubesoft.com>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@96163 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-01 02:07:28 +00:00
ian%hixie.ch
1e260d62d7 * fixing some syntactic errors
* added addUserGroup and removeUserGroup to the data source interface for users
* added some comments
* changed many double quotes |"| to single quotes |'| where double quotes were not needed
* implemented the remaining methods for the MySQL implementation of the user data source
* added a mode flag to user fields (idea from MattyT) so that fields can be disabled, hidden, etc


git-svn-id: svn://10.0.0.236/trunk@96152 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-01 00:32:35 +00:00
jake%acutex.net
ce19d8c942 Bugzilla was leaking information about bugs marked secure (using bug groups). This checkin fixes bugs 39524, 39527, 39531, and 39533.
Patches by Myk Melez <myk@mozilla.org>.
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@96121 18797224-902f-48f8-a5cc-f745e15eee43
2001-05-31 15:52:25 +00:00
jake%acutex.net
c462166cb5 Bug 80388 - cvsblame shouldn't require layers for popups
r=baloo


git-svn-id: svn://10.0.0.236/trunk@96073 18797224-902f-48f8-a5cc-f745e15eee43
2001-05-30 22:13:03 +00:00
jake%acutex.net
f097a8d6ae Fix for bug 45164 - New users created by the admin were not subject to the userregexp for groupsets.
Patch by Joe Robins <jmrobins@tgix.com>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@96059 18797224-902f-48f8-a5cc-f745e15eee43
2001-05-30 15:47:30 +00:00
justdave%syndicomm.com
4ee90b5c9c Dummy commit so I can put the attributions I forgot in the previous one.
Patch from bug 65290 was by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@96008 18797224-902f-48f8-a5cc-f745e15eee43
2001-05-29 21:27:12 +00:00
justdave%syndicomm.com
31f34d9a60 Fix for bug 65290: can now edit user-regexps for system groups
git-svn-id: svn://10.0.0.236/trunk@96007 18797224-902f-48f8-a5cc-f745e15eee43
2001-05-29 21:25:02 +00:00
ian%hixie.ch
66a92ef424 Change the semantics of address changing, making it faster, smaller, simpler, and better. Aaah... :-) In the new system, instead of cloning the current $session object to pass it back to the output code, you pass the real $session object to the output code, just making sure that the relevant field has been warned to return a different address than found in the database.
git-svn-id: svn://10.0.0.236/trunk@96006 18797224-902f-48f8-a5cc-f745e15eee43
2001-05-29 20:34:12 +00:00
justdave%syndicomm.com
cabe635fee Fix for bug 65399: Can't use string ("") as an ARRAY ref while "strict refs" in use at query.cgi due to no components defined in a product.
Patch by Matthias Radestock <matthias@sorted.org>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@96005 18797224-902f-48f8-a5cc-f745e15eee43
2001-05-29 20:30:51 +00:00
justdave%syndicomm.com
2595c439f3 Additional cleanup for bug 73191. newquip.html is no longer needed.
git-svn-id: svn://10.0.0.236/trunk@96004 18797224-902f-48f8-a5cc-f745e15eee43
2001-05-29 18:44:00 +00:00
ian%hixie.ch
7d520650d0 Adding some XXX comments regarding a known bug (when the user is changing their address, fields try to update the database before the new address has been authenticated)
git-svn-id: svn://10.0.0.236/trunk@95992 18797224-902f-48f8-a5cc-f745e15eee43
2001-05-29 09:11:33 +00:00
ian%hixie.ch
10a6e949df * Fixing a minor bug in the MySQL implementation of the string data source
* Started implementing the MySQL version of the user data source (completed so far: database creation and a few of the SELECT calls)
* Changed the user property 'disabled' to 'mode' to enable extensibility
* Fix a potential bug with changing addresses (make sure the fake session object doesn't update the database -- this is an incomplete solution so far, fields still have the bug)


git-svn-id: svn://10.0.0.236/trunk@95991 18797224-902f-48f8-a5cc-f745e15eee43
2001-05-29 09:07:10 +00:00
justdave%syndicomm.com
ce5edda180 Fix for bug 78045: change references to README in error messages to point to the Bugzilla Guide instead.
Patch by Matthew Tuck <matty@chariot.net.au>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@95989 18797224-902f-48f8-a5cc-f745e15eee43
2001-05-29 08:10:28 +00:00
justdave%syndicomm.com
f38e65caa5 Landing quips.cgi (bug 73191) by Owen Taylor <otaylor@redhat.com>
Submitted by Martin Baulig <baulig@suse.de> from bugzilla.gnome.org
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@95987 18797224-902f-48f8-a5cc-f745e15eee43
2001-05-29 04:01:48 +00:00
justdave%syndicomm.com
c8649e18e3 Fix for bug 77699 and bug 71503: fix javascript errors in quicksearch and improve IE5 compatibility
Patch by Stephan Lee <slee@uk.bnsmc.com> and Andreas Franke <afranke@ags.uni-sb.de>


git-svn-id: svn://10.0.0.236/trunk@95985 18797224-902f-48f8-a5cc-f745e15eee43
2001-05-29 03:05:46 +00:00
ian%hixie.ch
3bf5452821 * Moving 'type' to the front of the list of things returned by the User data source's 'getField*' methods so that they map more directly to the user field constructor arguments
* Moving 'typeData' around in the order of the user field constructor arguments to match the User data source's 'getField*' methods so that, again, they map more directly
* Renaming the 'getFieldFrom*' methods to 'getFieldBy*' to be consistent with 'getUserBy*'
* Implemented UserFieldFactory.pm
* Implemented Passwords.pm


git-svn-id: svn://10.0.0.236/trunk@95980 18797224-902f-48f8-a5cc-f745e15eee43
2001-05-28 23:43:56 +00:00
ian%hixie.ch
db3ed07d92 * Correcting a typo in Input.pm
* Added a comment to DataSource/User.pm explaining how (typically) to search for a username
* Fleshed out the DataSource/User.pm API by adding some schema management methods
* Added notes on which fields in the database schema should be keys
* Added comment to Service/User.pm noting the difference between Objects, Services, and Service Instances
* Changed 'user.field.factory' to 'user.fieldFactory' to prevent a namespace collision with 'user.field.(type)'
* Calling 'insertField' in one case which I missed when adding the method
* Implemented 'hash', 'joinGroup', 'invalidateRights', 'writeProperties' and 'writeGroups'
* Changed Service/UserField.pm so that one user field class can be used for any category
* Added a 'username' convenience method and implemented 'write'
* Added a comment to Service/UserFieldFactory.pm explaining how it should work
* Removed the 'user.field.generic.generic' field implementation, replaced it with a simpler 'user.field.string' implementation


git-svn-id: svn://10.0.0.236/trunk@95977 18797224-902f-48f8-a5cc-f745e15eee43
2001-05-28 20:09:23 +00:00
jake%acutex.net
9cde1e2552 Bug 79739 - Initial Owner and QA Contact were not being handled correctly by the email interface after they were changed to userid's in bug 66876.
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@95906 18797224-902f-48f8-a5cc-f745e15eee43
2001-05-25 12:48:47 +00:00