supporting marquee tag.
few new files are added and makefile.xxx are modified.
/r=timeless, dveditz /sr=jst, /a=jaime
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@125676 18797224-902f-48f8-a5cc-f745e15eee43
fix a misuse of parenthesis
p= Andrew Schultz r=bstell, sr=rbs, a=brendan
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@125522 18797224-902f-48f8-a5cc-f745e15eee43
This causes the SOAP HTTPS transport object to implement the proper interfaces,
as HTTP does, so that it will work. Very minimal risk because change is to an
object that was otherwise broken and only used by HTTPS. This permits users of
SOAP to use secure https transport for e-commerce or other transactions that
need to be secure. Has been checked in on the trunk for a while and verified.
This is only even loaded as paert of the xmlextras module.
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@125426 18797224-902f-48f8-a5cc-f745e15eee43
"sizeof" of the DEVMODE struct, instead of checking the struct size with dmSize
and the size of the private (device-specific) data with dmDriverExtra. Now it
creates the correct size of memory and copies all the non-private data and private data.
Bug 156318 r=dcone sr=kin,waterson,rpotts a=asa adt=putterman
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@125383 18797224-902f-48f8-a5cc-f745e15eee43
r=wtc, sr=blizzard, a=chofmann
OS/2 only - don't try to escape quotation marks when using DosStartSession
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@125376 18797224-902f-48f8-a5cc-f745e15eee43
r=dougt, sr=blizzard, a=chofmann
OS/2 only - up the number of file handles when starting Moz, and handle specific error with DosCopy
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@125375 18797224-902f-48f8-a5cc-f745e15eee43
r=pedemont, sr=blizzard, a=chofmann
OS/2 only - truncate title bar text to 256 to workaround OS bug
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@125371 18797224-902f-48f8-a5cc-f745e15eee43
r=pedemont, sr=blizzard (platform specific code), a=valeski
OS/2 only - addition to already approved fix for bug that works around a bad computation on 800x600
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@125328 18797224-902f-48f8-a5cc-f745e15eee43
r=pedemont, sr=blizzard (platform specific code), a=valeski
OS/2 only - add a preference to enable trackpoint scrolling by creating invisible scrollbars on all windows
Relanding after bustage
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@125327 18797224-902f-48f8-a5cc-f745e15eee43
unable to load ./libmozpango-thaix.so
modified pango.modules to fix the location of the .so
r=Roland.Mainz@informatik.med.uni-giessen.de
sr=sfraser,a=chofmann
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@125278 18797224-902f-48f8-a5cc-f745e15eee43
tis620-2 is not defined as th language group
added tis620-2 entry as language Thai
r=ftang,sr=sfraser,a=chofmann
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@125277 18797224-902f-48f8-a5cc-f745e15eee43
get or set cookies for URL schemes which do not support the host field.
r=morse, sr=jst, dveditz, a=asa.
Bug 149943 - "pin" hostnames to IP numbers for the duration of a session to
prevent DNS spoofing. Patch by darin, r=dougt, sr=dveditz, a=asa
Bug 154930 - Prevent another DNS spoofing attack by restricting use of
document.domain. r=dveditz, sr=jst, a=valeski
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@125141 18797224-902f-48f8-a5cc-f745e15eee43
Contained referenced to mIsScrollBar which exists in trunk, but not in branch
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@125007 18797224-902f-48f8-a5cc-f745e15eee43
add a way to create custom files for components
WINDOWS ONLY
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@125005 18797224-902f-48f8-a5cc-f745e15eee43
r=pedemont, sr=blizzard (platform specific code), a=valeski
OS/2 only - add a preference to enable trackpoint scrolling by creating invisible scrollbars on windows
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@124987 18797224-902f-48f8-a5cc-f745e15eee43
r=pedemont, sr=blizzard (platform specific code), a=valeski
OS/2 only - don't draw any rectangles if width is 0
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@124986 18797224-902f-48f8-a5cc-f745e15eee43
r=pedemont, sr=blizzard (platform specific code), a=valeski
OS/2 only - don't let Mozilla windows cover up the Warpcenter
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@124985 18797224-902f-48f8-a5cc-f745e15eee43
mozilla. r=dougt,sr=rpotts. Help Windows NT, 2000, and XP dialup a RAS
connection when a network address is unreachable. The controlling pref
is "network.autodial-helper.enabled". Patch by smeredith, all credits
to him :-)
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@124900 18797224-902f-48f8-a5cc-f745e15eee43
of the document (mail msg) is done loading. This is wrong because if the mail
msg has attachments they may not be loaded and then the msgPrintEngine gets
additional notification for when the attachments have started to load and since
it has already started toprint error dialogs appear AND the attachments don't get printed.
The solution here is to cache a pointer to the DOM Window for the msg(s) being
printed. Then as the "stop" notifications come in we can ignore any documents
(which would be the attachments) where the dom window doesn't match the msg's
dom window. Then when they match which is the last notifiaction we can call print.
The notification that comes thru where the docLoader is NULL means the previous
document has completed printing and the engine should print the next msg.
Bug 155430 r=cavin sr=kin/sspitzer adt=putterman a=chofmann
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@124806 18797224-902f-48f8-a5cc-f745e15eee43
The patch allows Administrators to control the migration behavior wrt IMAP and Local Folders files. Today, during migration, we copy all those (IMAP & Local Folders) besides others into the newly created dierctory for the migrated profile. Some external parties have expressed concern over this approach due the large amount of mails they have in 4.x folders and all of those getting copied again wasting the disk space and also making the migration too slow. So, a hidden pref mail.migration.copyMailFiles is introduced (which can be set to false) for those who those interested to share the 4.x IMAP and Local Folders. Please see the bug report for the possible side effects and other discussion points wrt the sharing folders with 4.x. The pref is set to true by default which means we will continue to do the migration the way we have always done.
Patch by henry.jia@sun.com. r=racham, sr=sspitzer, a=chofmann
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@124665 18797224-902f-48f8-a5cc-f745e15eee43
r=dbradley sr=brendan a=chofman
this patch is not identical to the trunk, to compile some blocks of code were moved around
also the trunk has ACQUIRE_DTOA_LOCK() whereas the branch has ACQUIRE_DTOA_LOCK(n).
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@124581 18797224-902f-48f8-a5cc-f745e15eee43
r=pedemont, sr=blizzard, a=valeski
OS/2 only - get NPNULL plugin working on OS/2 - somehow I forgot these files
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@124576 18797224-902f-48f8-a5cc-f745e15eee43
stringwas dependent, extracted bad value for subsequent memory request.
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@124522 18797224-902f-48f8-a5cc-f745e15eee43
r=varga sr=kin a=valeski
<grid></grid> with no rows or collumns
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@124521 18797224-902f-48f8-a5cc-f745e15eee43
Cannot type in URL/address/location bar or text boxes - no caret/cursor. (Keyboard locks/freezes up / no input)
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@124485 18797224-902f-48f8-a5cc-f745e15eee43
automatically, but the user sure thinks we do). r=law, sr=jag,
a=chofmann
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@124441 18797224-902f-48f8-a5cc-f745e15eee43
r=pedemont, sr=blizzard, a=valeski
OS/2 only - display Euro using current font, not Unicode font
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@124370 18797224-902f-48f8-a5cc-f745e15eee43
r=cls, a=valeski
OS/2 only - get NPNULL plugin working on OS/2
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@124368 18797224-902f-48f8-a5cc-f745e15eee43
r=pedemont, sr=blizzard, a=valeski
OS/2 only - get NPNULL plugin working on OS/2
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@124367 18797224-902f-48f8-a5cc-f745e15eee43
r=mkaply, sr=blizzard, a=valeski
OS/2 only from jblanco - only set number of copies in one place
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@124362 18797224-902f-48f8-a5cc-f745e15eee43
r=bnesse, sr=jst, a=valeski
OS/2 only - skip over EOF character on JS files in prefs
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@124361 18797224-902f-48f8-a5cc-f745e15eee43
r=jeffreyj@us.ibm.com, sr=blizzard, a=valeski
Take Windows code - keep a handle on window during deletion to prevent crash
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@124360 18797224-902f-48f8-a5cc-f745e15eee43
r=mkaply, sr=jag, a=valeski
Regression in RFind - -1 should be default offset, not 0
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@124355 18797224-902f-48f8-a5cc-f745e15eee43
-fshort-wchar for g++.
Include <stddef.h> instead of <stdlib.h> in wchar_t tests to avoid exit() declar
ation issues with autoconf.
Bug #139211 r=bryner,dbaron a=dbaron
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@124349 18797224-902f-48f8-a5cc-f745e15eee43
Use same modulename for xlib module in Makefile as the code uses.
Bug #144182 r=bryner a=dbaron
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@124347 18797224-902f-48f8-a5cc-f745e15eee43
Thanks to Andrew Schultz <ajschult@eos.ncsu.edu> for the patch.
Bug #57866 r=cls a=valeski
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@124294 18797224-902f-48f8-a5cc-f745e15eee43
Thanks to srilatha@netscape.com for the patch.
r=cls, sr=sspitzer a=dbaron
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@124290 18797224-902f-48f8-a5cc-f745e15eee43
Frequency analysis is only applied to euc clone encoding, and gb18030 is
not one of it. The existence of gb18030 will prevent frequency sampling from
happening. So eliminate gb18030 when considering frequency sampling.
r=ftang, sr=jst a=adt, valeski
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@124252 18797224-902f-48f8-a5cc-f745e15eee43
just copy over the source URL and other relevant fields (to avoid copying event
handlers). r=bzbarsky, sr=jag, a=valeski. Patch by jrgm@netscape.com.
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@124219 18797224-902f-48f8-a5cc-f745e15eee43
Don't enter pause dialog if http response indicates an error
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@124160 18797224-902f-48f8-a5cc-f745e15eee43
it is one of our objects before doing the static cast.
Bug 106211 r=pink sr=jst a=dbaron adt=jaime
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@123967 18797224-902f-48f8-a5cc-f745e15eee43
BeginObservingDocument was already called. This means the PresShell is still
registered as an observer of the document and then later can cause a crash when
the document loops thru the observer list.
Bug 152536 r=dcone sr=jst a=jud adt=paw
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@123966 18797224-902f-48f8-a5cc-f745e15eee43
let config.ini control cleanup of previous version reg keys
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@123962 18797224-902f-48f8-a5cc-f745e15eee43
make superseded components invisible in selection lists
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@123961 18797224-902f-48f8-a5cc-f745e15eee43
r=jeffreyj@us.ibm.com, sr=mscott, a=valeski
OS/2 only - support for new mail notification in the OS
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@123917 18797224-902f-48f8-a5cc-f745e15eee43
r=wtc, a=dbaron
OS/2 only - DosWrite is not returning an error when the disk is full.
We can tell the write failed if we did a partial write.
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@123911 18797224-902f-48f8-a5cc-f745e15eee43
AMPM order needs to be cared in time format
check the order AM/PM string from strftime()
r=yokoyama,sr=blizzard,a=valeski@netscape.com
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@123864 18797224-902f-48f8-a5cc-f745e15eee43
Stop caching jsdIValues, it doesn't seem to be worth the lookup cost. This has the side effect of plugging the leak, as described in the bug.
also...
* Convert a few raw pointers to nsCOMPtrs
* Fix a bug where removing the last filter did not null out the list head,
causing a crash the next time filters were used.
* Track live jsdStackFrames, so we can invalidate them all when execution
continues. Without this, only the top frame is properly invalidated, and any
other frame accessed after a continue will do Bad Things.
* Add some debugging prints to GetInitAtService, which seems to be failing at
random times.
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@123855 18797224-902f-48f8-a5cc-f745e15eee43
CJK IME text input related bug fixes.
/r=shanjian,/sr/brendan,/driver=jud,/adt=ok
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@123851 18797224-902f-48f8-a5cc-f745e15eee43
to detect insufficient input data error. With mozilla1.0.1+ and adt1.0.1+
approvals.
Tag: MOZILLA_1_0_BRANCH
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@123818 18797224-902f-48f8-a5cc-f745e15eee43
include license.txt with saved files when saving installer files
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@123779 18797224-902f-48f8-a5cc-f745e15eee43
r=rods, sr=jst, a=valeski
OS/2 - Just return if there are no printers to prevent crash
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@123707 18797224-902f-48f8-a5cc-f745e15eee43
r=timeless, sr=jag, a=valeski
Windows - map + on numpad to + character
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@123703 18797224-902f-48f8-a5cc-f745e15eee43
on copying msg because sent folder was being subscribed again.
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@123647 18797224-902f-48f8-a5cc-f745e15eee43
instead of Sender and localizing webmail "Sent" and "Draft" folder
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@123637 18797224-902f-48f8-a5cc-f745e15eee43
in the process of destruction when windows are destroyed be cause setfocus
causes the flush of reflow commands
r=kmcclusk sr=waterson a=rjesup
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@123623 18797224-902f-48f8-a5cc-f745e15eee43
force default size to be 9 when system says 8 for simplified chinese system.
r=ftang, sr=alecf, a=adt
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@123562 18797224-902f-48f8-a5cc-f745e15eee43
r=jpierre, sr=blizzard, a=dbaron
OS/2 only - int32 math causing incorrect computation of disk space
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@123250 18797224-902f-48f8-a5cc-f745e15eee43
r=jkobal, sr=blizzard, a=dbaron
OS/2 only -handle special case of WM_QUIT so we don't stop the OS from shutting down
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@123249 18797224-902f-48f8-a5cc-f745e15eee43
Thanks to Chris Blizzard <blizzard@mozilla.org> for the patch.
Bug #149483 r=cls a=valeski
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@123217 18797224-902f-48f8-a5cc-f745e15eee43
swap the order of weakdoc charset and default charset so that previous
doc charset can be inherited as default charset.
disabled charset autodetection for post document.
r=ftang, sr=darin, a=adt,
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@123201 18797224-902f-48f8-a5cc-f745e15eee43
r=mkaply, sr=blizzard, a=valeski
OS/2 only - when rods checked in 144128, he missed the OS/2 changes.
146252 is OS/2 print preview fixes. It has been over three days since
approval, but I couldn't check it in until the rods stuff was figured out.
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@123079 18797224-902f-48f8-a5cc-f745e15eee43
b=145388; r=dcone; sr=attinasi; a=chofmann
(checking in for rods; required for bug 133506)
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@123032 18797224-902f-48f8-a5cc-f745e15eee43
fix typo - [noscrpit] was used instead of [noscript]
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@122981 18797224-902f-48f8-a5cc-f745e15eee43
bug 137141 - Wrong context menu items in stand alone mail window
bug 138826 - context menu problems in stand alone message window: "Open Link in New Window" doesn't work, too many items are showing up, etc.
r=neil@parkwaycc.co.uk, sr=sspitzer, a=drivers,adt
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@122955 18797224-902f-48f8-a5cc-f745e15eee43
+ if (_tcscmp(lpInfo[i].pPrinterName, aPrinterName) == 0) {
I also removed the failure check after the calls to EnumerateNativePrinters
because even if one fails, it doesn't mean the others will. So it should keep trying.
The rest of the code is extra error checking that is all ifdef'ed out
Bug 143241 r=dcone sr=kin adt=putterman a=jud
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@122886 18797224-902f-48f8-a5cc-f745e15eee43
for future and is needed for the API freeze.
Bug 144716 r=dcone sr=attinasi adt=putterman a=jud
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@122884 18797224-902f-48f8-a5cc-f745e15eee43
This patch does the following:
1) Introduces a new public interface nsIPrintSettingService which emables
consumers to create PS objects whithout a nsIWebBrowserPrint interface
2) The implementation is nsPrintOptionsImpl which now impls the private
interface nsIPrintOptions and the public iface nsIPrintSettingsService
3) Several methods/attrs have been moved from nsIWebBrowserPrint iface to nsIPrintSettingsService
4) The CIDs for nsIPrintOptions and nsIPrinSettingsService are now the same.
5) There is no longer a CID "@mozilla.org/gfx/printoptions;1"
6) nsIWebBrowserPrint still has the "globalPrintSettings" attr so if you
already have an nsIWebBrowserPrint you don't have to create the PS Service to get it.
7) A bug has been filed to rename the imlp of nsPrintOptionsImpl to nsPrintSettingsService.
Bug 144128 r=dcone sr=kin adt=putterman a=jud
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@122882 18797224-902f-48f8-a5cc-f745e15eee43
This patch does the following:
1) Introduces a new public interface nsIPrintSettingService which emables
consumers to create PS objects whithout a nsIWebBrowserPrint interface
2) The implementation is nsPrintOptionsImpl which now impls the private
interface nsIPrintOptions and the public iface nsIPrintSettingsService
3) Several methods/attrs have been moved from nsIWebBrowserPrint iface to nsIPrintSettingsService
4) The CIDs for nsIPrintOptions and nsIPrinSettingsService are now the same.
5) There is no longer a CID "@mozilla.org/gfx/printoptions;1"
6) nsIWebBrowserPrint still has the "globalPrintSettings" attr so if you
already have an nsIWebBrowserPrint you don't have to create the PS Service to get it.
7) A bug has been filed to rename the imlp of nsPrintOptionsImpl to nsPrintSettingsService.
Bug 144128 r=dcone sr=kin adt=putterman a=jud
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@122881 18797224-902f-48f8-a5cc-f745e15eee43
Modified SlideLine() to use the combined area instead of the linebox
bounds when invalidating. This makes sure that we invalidate the
area occupied by the list bullets/ordinals.
r=dbaron@fas.harvard.edusr=waterson@netscape.coma=valeski@netscape.com
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@122874 18797224-902f-48f8-a5cc-f745e15eee43
The listener is deconstructed and it is still registered as a listener, so in some cases a blur event goes to the old listener that is why it crashes.
Bug 132672 r=dcone sr=jst adt=putterman a=jud
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@122773 18797224-902f-48f8-a5cc-f745e15eee43
pop3 mail on biff, also fix other related problems
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@122724 18797224-902f-48f8-a5cc-f745e15eee43
add SupersedeMinVersion to components in win32 installer
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@122665 18797224-902f-48f8-a5cc-f745e15eee43
- this site crashes the browser, every time]" r=dougt sr=rpotts a=chofmann ADT+
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@122651 18797224-902f-48f8-a5cc-f745e15eee43
r=timeless, sr=hewitt, a=chofmann
return FAILURE rather than crashing when output stream can't be opend
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@122618 18797224-902f-48f8-a5cc-f745e15eee43
Use "sourceTextEncoding" to convert search name and description,
bug 92314, r=rjc, sr=alecf.
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@122615 18797224-902f-48f8-a5cc-f745e15eee43
Modified TypeInState::NotifySelectionChanged() to work around
bogus selection changed notifications (bug 140303). We now
call reset when the collapsed selection changes position, or
becomes uncollapsed.
mozilla/editor/libeditor/html/TypeInState.cpp
mozilla/editor/libeditor/html/TypeInState.h
r=jfrancis@netscape.comsr=attinasi@netscape.coma=chofmann@netscape.com
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@122590 18797224-902f-48f8-a5cc-f745e15eee43
Don't call StopBlinking() if the selection changed notification is
for a selection that is different from the one in mDomSelectionWeak.
r=akkana@netscape.comsr=attinasi@netscape.coma=chofmann@netscape.com
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@122589 18797224-902f-48f8-a5cc-f745e15eee43
r=pedemont, sr=blizzard, a=valeski
OS/2 only - make focus code work more like Windows
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@122517 18797224-902f-48f8-a5cc-f745e15eee43
r=pedemont, sr=blizzard, a=valeski
OS/2 only - don't write an extra NULL char to URL objects
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@122516 18797224-902f-48f8-a5cc-f745e15eee43
r=pedemont, sr=blizzard, a=valeski
OS/2 only - suppot for custom splash screen - same as Win - thanks to Bjorn Anderson for the sample code
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@122514 18797224-902f-48f8-a5cc-f745e15eee43
Quick Launch: After an exit, IMAP password dialog may appears with Biff and "Check new message on startup" setup.
r=naving,sr=mscott,a=adt,a=rjesup
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@122495 18797224-902f-48f8-a5cc-f745e15eee43
SetFont API has been changed in nsIRenderingContext, need to change
nsRenderingContextBeOS.h as well.
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@122483 18797224-902f-48f8-a5cc-f745e15eee43
Solaris specific mime names are not supported in Mozilla/Netscape Mail
Added some lines for chinese and TIS-620 for iso8859-11
r=ftang, sr=alecf, a=rjesup@wgate.com
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@122458 18797224-902f-48f8-a5cc-f745e15eee43
Update gb18030 statemachine, and use gb18030 state machine to
replace gb2312.
r=ftang, sr=scc, a=adt
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@122454 18797224-902f-48f8-a5cc-f745e15eee43
changed nsRenderingContext API, and let GetMetricsFor
take lang group as a required argument. Changed all such
calls. Implement a convenient function to simplifed the
code.
r=rbs, sr=waterson, a=adt, rjesup
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@122452 18797224-902f-48f8-a5cc-f745e15eee43
Error in walletOverlay.js on startup [redeclaration of const hide]
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@122417 18797224-902f-48f8-a5cc-f745e15eee43
- IME input repositioning of Candidate window
- affect Windows 2000/XP - Simplified Chinese and MS PinYing and NeiMa IME only
/r=shanjian; /sr=brendan, /drivers=jud, /adt1.0.1=jaime
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@122346 18797224-902f-48f8-a5cc-f745e15eee43
if a bunch of people get mozilla 1.0, they'll overload tbox.
r=callion,sr=bienvenu,a=leaf
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@122267 18797224-902f-48f8-a5cc-f745e15eee43
rg/projects/embedding/MRE.html for details.)
Changes:
* Added EXTRA_COMPONENTS variable to build. Use it to automagically install files
into the components dir.
* Added SYSINSTALL variable. Use it install files onto the system.
* Move mozilla-config generation from configure to makefiles
* mozilla-config will now generate paths based upon the MRE-based directory layout.
* Generate mozilla script from template
The installation heirarchy currently looks like:
$prefix -> /bin/mozilla
/bin/mozilla-config
/include/mozilla-ver/*
/lib/mozilla-ver (mozappdir)
/components
/res
/defaults
/chrome
There is preliminary build support for MRE dirs as well though the component manage
r hasn't had MRE support added yet.
$prefix -> /lib/mre/mre-ver (mredir)
/components
Bug #56601 r=leaf a=scc,shaver,tor
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@122149 18797224-902f-48f8-a5cc-f745e15eee43
rg/projects/embedding/MRE.html for details.)
Changes:
* Added EXTRA_COMPONENTS variable to build. Use it to automagically install files
into the components dir.
* Added SYSINSTALL variable. Use it install files onto the system.
* Move mozilla-config generation from configure to makefiles
* mozilla-config will now generate paths based upon the MRE-based directory layout.
* Generate mozilla script from template
The installation heirarchy currently looks like:
$prefix -> /bin/mozilla
/bin/mozilla-config
/include/mozilla-ver/*
/lib/mozilla-ver (mozappdir)
/components
/res
/defaults
/chrome
There is preliminary build support for MRE dirs as well though the component manage
r hasn't had MRE support added yet.
$prefix -> /lib/mre/mre-ver (mredir)
/components
Bug #56601 r=leaf a=scc,shaver,tor
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@122148 18797224-902f-48f8-a5cc-f745e15eee43
rg/projects/embedding/MRE.html for details.)
Changes:
* Added EXTRA_COMPONENTS variable to build. Use it to automagically install files
into the components dir.
* Added SYSINSTALL variable. Use it install files onto the system.
* Move mozilla-config generation from configure to makefiles
* mozilla-config will now generate paths based upon the MRE-based directory layout.
* Generate mozilla script from template
The installation heirarchy currently looks like:
$prefix -> /bin/mozilla
/bin/mozilla-config
/include/mozilla-ver/*
/lib/mozilla-ver (mozappdir)
/components
/res
/defaults
/chrome
There is preliminary build support for MRE dirs as well though the component manage
r hasn't had MRE support added yet.
$prefix -> /lib/mre/mre-ver (mredir)
/components
Bug #56601 r=leaf a=scc,shaver,tor
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@122145 18797224-902f-48f8-a5cc-f745e15eee43
Changes:
* Added EXTRA_COMPONENTS variable to build. Use it to automagically install files into the components dir.
* Added SYSINSTALL variable. Use it install files onto the system.
* Move mozilla-config generation from configure to makefiles
* mozilla-config will now generate paths based upon the MRE-based directory layout.
* Generate mozilla script from template
The installation heirarchy currently looks like:
$prefix -> /bin/mozilla
/bin/mozilla-config
/include/mozilla-ver/*
/lib/mozilla-ver (mozappdir)
/components
/res
/defaults
/chrome
There is preliminary build support for MRE dirs as well though the component manager hasn't had MRE support added yet.
$prefix -> /lib/mre/mre-ver (mredir)
/components
Bug #56601 r=leaf a=scc,shaver,tor
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@122141 18797224-902f-48f8-a5cc-f745e15eee43
Changes:
* Added EXTRA_COMPONENTS variable to build. Use it to automagically install files into the components dir.
* Added SYSINSTALL variable. Use it install files onto the system.
* Move mozilla-config generation from configure to makefiles
* mozilla-config will now generate paths based upon the MRE-based directory layout.
* Generate mozilla script from template
The installation heirarchy currently looks like:
$prefix -> /bin/mozilla
/bin/mozilla-config
/include/mozilla-ver/*
/lib/mozilla-ver (mozappdir)
/components
/res
/defaults
/chrome
There is preliminary build support for MRE dirs as well though the component manager hasn't had MRE support added yet.
$prefix -> /lib/mre/mre-ver (mredir)
/components
Bug #56601 r=leaf,a=scc,shaver,tor
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@122140 18797224-902f-48f8-a5cc-f745e15eee43
"BinarySearchForPosition" code from the nsTextFrame for finding cursor
position. Instead of cursor position, it is just uses the available width.
Bug 139384 r=dcone sr=attinasi a=chofmann,rjesup adt=putterman
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@122019 18797224-902f-48f8-a5cc-f745e15eee43
Not part of the build. Global a= for this part of the tree.
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@122010 18797224-902f-48f8-a5cc-f745e15eee43
correct state machine of gb18030, and eliminate gb18030 as option
when only 2 candidates left.
r=ftang, sr=scc, a=chofman, adt
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@122004 18797224-902f-48f8-a5cc-f745e15eee43
FTP site is broken for Japanese server
Impact for only displaying ftp directory listing.
/r=bbaetz,/sr=darin,/a=chofmann,/adt=putterman
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@121979 18797224-902f-48f8-a5cc-f745e15eee43
Retrieve IMEProperty by calling ImmGetProperty() and
determine if the IME supports W API.
Impact only in Win2k and WinXP Simplified Chinese platforms
/r=shanjian,/sr=kin@netscape.com
/adt=putterman,/a=permission call from driver@mozilla.org
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@121978 18797224-902f-48f8-a5cc-f745e15eee43
r/sr=dmose, darin, jag, mozbot, lumpy, callion, jst, akkana (various parts of various patches, after baking on the trunk for a while)
a=chofmann
adt=jaimejr
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@121959 18797224-902f-48f8-a5cc-f745e15eee43
the branch (i backed it out late last night to see).
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@121940 18797224-902f-48f8-a5cc-f745e15eee43
due to nonexistent favorites folder (Windows 95 without IE4+ does not have
a favorites folder, so null check before using it)
r=ftang, sr=hyatt, a=rjesup
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@121869 18797224-902f-48f8-a5cc-f745e15eee43
correctly. Patch by morse, r=pinkerton, sr=alecf, a=drivers for the branch.
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@121847 18797224-902f-48f8-a5cc-f745e15eee43
r=gerv, sr=alecf, a=chofmann,brendan
OS/2 only if statement - Os/2 has different default DPI values
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@121828 18797224-902f-48f8-a5cc-f745e15eee43
(results possibly in an kill because of out of memory)"
patch1: author=gordon r=dougt sr=darin
patch2: author=darin r=gordon,dougt sr=rpotts
a=brendan
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@121822 18797224-902f-48f8-a5cc-f745e15eee43
Thanks to Colin Blake <colin@theblakes.com> for the original patch.
Bug #127442 r=bryner a=chofmann
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@121726 18797224-902f-48f8-a5cc-f745e15eee43
Note: "512 is a good compromise between the transport speed and the system memor
y resources consumed."
Thanks to Jeff Wasilko <jw-mozilla@smoe.org> for the patch.
Bug #118846 r=cls a=rjesup@wgate.com
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@121717 18797224-902f-48f8-a5cc-f745e15eee43
r=bzbarsky, sr=blizzard, a=chofmann
OS/2 only - new helper app code - more like unix - new protoocl handler code
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@121634 18797224-902f-48f8-a5cc-f745e15eee43
r=me,sr=blizzard, a=chofmann
OS/2 only - change splash from Warpzila to Mozilla
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@121632 18797224-902f-48f8-a5cc-f745e15eee43
2) It can be difficult to determine whether you are creating/reflowing a UI or
doc scrollbar (SB)
3) They share the same PresContext which has a single scale value that UI SBs
need to ignore, but the doc SBs need to use.
This patch does the following:
1) Enables the PrintPreviewContext to turn on and of the scaling of twips
2) When creating a new scrollbar, it checks to see if the frame parent is
is a viewportframe that way it knows if it is in the UI or in the document
then for UI scrollbars it turns off the saling, and for doc scrollbars it
turns it on. This needs to be done at creation time as well as, reflow
because it GetScaledPixelsToTwips get called during both.
3) The nsSimpleSequenceFrame turns on scaling during its children reflow
then turns it off.
4) When PrintPreview "setup" is done it turns off the scaling in the
PrintPreviewContext because any reflowing other usages for
GetScaledPixelsToTwips will be for UI scrollbars
5) A copy of all the style rules for scrollbars is made and placed inside of
a media type "print" This way the style resultion for the scaled scrollbars
in the document are not shared with the UI.
Bug 120616 r=dcone sr=attinasi adt=putterman a=chofmann
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@121622 18797224-902f-48f8-a5cc-f745e15eee43
bug 143503, "long channel topic isn't wrapped properly"
r=samuel@sieb.net, sr=shaver@mozilla.org, a=leaf@mozilla.org
insert spaces in long topic words so things can wrap.
bug 140088, "Chatzilla is crashing when switching tabs."
r=samuel@sieb.net, sr=shaver, a=rjesup@wgate.com
don't touch the tree selection while the tree is hidden.
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@121577 18797224-902f-48f8-a5cc-f745e15eee43
from the previous PP data object instead of fetching it from the DC, the DC
contains the current value and it may not represent what is actually the
Original value.
Bug 139459 r=dcone sr=attinasi a=asa,rjesup adt=putterman
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@121526 18797224-902f-48f8-a5cc-f745e15eee43
r=bengoodger, sr=hewitt, a=chofmann on behalf of drivers
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@121505 18797224-902f-48f8-a5cc-f745e15eee43
On CJK system, we have to use mbsrchr to identify the last "\" of a string.
r=dougt, sr=alecf, a=asa, adt
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@121455 18797224-902f-48f8-a5cc-f745e15eee43
r=nhotta, sr=blizzard, a=rjesup
New enum for specifying charset of 4.x prefs.js
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@121454 18797224-902f-48f8-a5cc-f745e15eee43
r=nhotta, sr=blizzard, a=rjesup
New enum for specifying charset of 4.x prefs.js
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@121453 18797224-902f-48f8-a5cc-f745e15eee43
r=pedemonte, sr=blizzard, a=rjesup
OS/2 only - use button 2 for drag
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@121449 18797224-902f-48f8-a5cc-f745e15eee43
s up in debug builds.
Bug #138726 r=rginda sr=alecf a=rjesup
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@121365 18797224-902f-48f8-a5cc-f745e15eee43
r=tao, sr=jag, a=asa
(no adt because this is a licensing-only change, no code is changed here)
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@121359 18797224-902f-48f8-a5cc-f745e15eee43
sr=blizzard, a=rjesup/asa/etc (checking in for Blake at Asa's request).
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@121252 18797224-902f-48f8-a5cc-f745e15eee43
addressbook export to ldif, re-import is lossy.
fix two issue, multi line attributes need to be base64 encoded
and there are several attributes that are not being exported / imported.
r=dmose, sr=bienvenu. a=putterman,asa
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@121251 18797224-902f-48f8-a5cc-f745e15eee43
r=mkaply, sr=blizzard, a=rjesup
OS/2 only - code from Jessica Blanco - don't use CRLF in printer names
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@121246 18797224-902f-48f8-a5cc-f745e15eee43
r=pinkerton, sr=jst, a=asa
Change for OS/2 only - use right mouse button for drag
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@121244 18797224-902f-48f8-a5cc-f745e15eee43
Can't turn on IM after a popup window opens
Call SetFocus() of XIC again to the current focused widget
r=blizzard,sr=shaver,a=asa(for1.0branch)
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@121232 18797224-902f-48f8-a5cc-f745e15eee43
Bug 140088 Chatzilla is crashing when switching tabs.
rs=blizzard, a=asa
spackle to avoid crasher. don't tweak the tree root if the tree isn't visible.
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@121223 18797224-902f-48f8-a5cc-f745e15eee43
sent with a 'Last-Modified' header"
r=bbaetz sr=rpotts a=valeski,chofmann ADT+
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@121128 18797224-902f-48f8-a5cc-f745e15eee43
and document.load calls. Also enable HTTP basic-auth dialog for both functions.
r=heikki, jst sr=jband, a=chofmann, putterman
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@121049 18797224-902f-48f8-a5cc-f745e15eee43
patch=jst, r=rginda, sr=hyatt, a=asa
clear element box object when the element is removed from the document.
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@120918 18797224-902f-48f8-a5cc-f745e15eee43
up some interfaces into separate IDL files (b=124465)
reviewed by dougt and bbaetz
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@120799 18797224-902f-48f8-a5cc-f745e15eee43
forcing a min height and min width on the the tree. This fixes the famous 100 % CPU hang.
Patch from kin@netscape.com
r=mscott
sr=hyatt
a=asa
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@120763 18797224-902f-48f8-a5cc-f745e15eee43
Mail/News only. Freeze when user scroll the msg header.
- infinite loop caused by creating an invalid UTF-8 string.
- invalid UTF-8 string was created when Unicode Decoder failed.
/r=nhotta, /sr=bienvenu, /a=asa, /adt=jaime
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@120757 18797224-902f-48f8-a5cc-f745e15eee43
correct the command name for the View->Open At Startup option
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@120752 18797224-902f-48f8-a5cc-f745e15eee43
Deleted a printf statement in the Neutrino builds. Bug 135692.
a=scc
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@120735 18797224-902f-48f8-a5cc-f745e15eee43
Not part of the build. Global a= for this part of the tree.
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@120670 18797224-902f-48f8-a5cc-f745e15eee43
thanks to dp for the fix. r=blizzard,sr=bienvenu,a=shaver
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@120642 18797224-902f-48f8-a5cc-f745e15eee43
profiles. r=ccarlen, sr=bievenu, a=chofmann. thanks to ccarlen for the
initial patch. by default, no re-migration for mozilla builds.
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@120637 18797224-902f-48f8-a5cc-f745e15eee43
Not part of the build. Global a= for this part of the tree.
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@120628 18797224-902f-48f8-a5cc-f745e15eee43
Not part of the build. Global a= for this part of the tree.
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@120621 18797224-902f-48f8-a5cc-f745e15eee43
r=pedemonte, sr=blizzard, a=rjesup
OS/2 only - don't add the hidden window to the task list
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@120598 18797224-902f-48f8-a5cc-f745e15eee43
launch. Don't null the filter list on server unless we are unloading it.
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@120471 18797224-902f-48f8-a5cc-f745e15eee43
Not part of the build. Global a= for this part of the tree.
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@120434 18797224-902f-48f8-a5cc-f745e15eee43
Not part of the build. Global a= for this part of the tree.
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@120433 18797224-902f-48f8-a5cc-f745e15eee43
The safety checks in finalize_translation is the key to stopping the crash, but
the added ones in end_document are important also.
Bug 139369 r=dcone,roland sr=attinasi adt=jaime
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@120427 18797224-902f-48f8-a5cc-f745e15eee43
patch was meant to land along with yesterday's pipelining landing.
r=gagan sr=rpotts a=chofmann ADT+
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@120315 18797224-902f-48f8-a5cc-f745e15eee43
Not part of the build. Global "a=" for this part of the tree.
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@120267 18797224-902f-48f8-a5cc-f745e15eee43
Not part of the build. Global "a=" for this part of the tree.
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@120266 18797224-902f-48f8-a5cc-f745e15eee43
Not part of the build; global "a=" for this part of the tree.
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@120251 18797224-902f-48f8-a5cc-f745e15eee43
Not part of the build; global "a=" for this part of the tree.
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@120250 18797224-902f-48f8-a5cc-f745e15eee43
Christof Meerwald.
Not part of the build; global "a=" for this part of the tree.
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@120249 18797224-902f-48f8-a5cc-f745e15eee43
r=pedemont, sr=blizzard, a=asa
OS/2 only - fix some edge cases where file dialog didn't appear, general cleanup
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@120245 18797224-902f-48f8-a5cc-f745e15eee43
Bug 89835: Window opened up with JavaScript has focus in the URL bar while NN4 and IE put focus on the content area
Focus will now always go to the content area unless we're opening for a blank page.
r=sgehani, sr=hewitt, a=drivers, a=adt
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@120186 18797224-902f-48f8-a5cc-f745e15eee43
nsAllocator with nsMemory.
Not part of the build; using global "a=" for this part of the tree.
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@120173 18797224-902f-48f8-a5cc-f745e15eee43
(configure.in change was made for :
#91305 add universal chardet into unix default extensions list.
That was checked in a week ago, but configure file is not updated yet.
)
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@120154 18797224-902f-48f8-a5cc-f745e15eee43
r=chak, sr=dveditz, a=dbaron
no ADT because this is simply a comment/doc change - there is no code involved.
trying to do the right thing here and just land this puppy.
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@120083 18797224-902f-48f8-a5cc-f745e15eee43
Allow the cache to grow if necessary to hold large objects. r=nelsonb,wtc.
a=asa (on behalf of drivers) for checkin to the 1.0 branch
Modified Files: h_bigkey.c hash_buf.c
Tag: MOZILLA_1_0_0_BRANCH
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@120076 18797224-902f-48f8-a5cc-f745e15eee43
work on Windows 95.
Modified files: configure configure.in WIN32.mk _win95.h w95dllmain.c
w95thred.c
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@120072 18797224-902f-48f8-a5cc-f745e15eee43
r=lpham, sr=leaf, a=asa for blanket version approval.
asasaki checking in as cltbld.
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@120045 18797224-902f-48f8-a5cc-f745e15eee43
bug 139883, "ErrorHookProc can be tricked into thinking it never finished running", r=peterv, a=scc
fixes bad early return in jsds_ErrorHookProc
test for correct max params (12, not 8) in CreatePPLineMap
use nsnull instead of 0 for null pointer return value
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@120001 18797224-902f-48f8-a5cc-f745e15eee43
ABBR and ACRONYM should not have arrow/question cursor
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@119996 18797224-902f-48f8-a5cc-f745e15eee43
possible relative url do not return an error when the urlparser
identifies an invalid scheme, instead take the string as relative url
instead, r=morse, sr=darin, a=asa
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@119995 18797224-902f-48f8-a5cc-f745e15eee43
name we use for regisry and path names
(Bug 140178, r=ssu, sr=dveditz, a=asa)
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@119941 18797224-902f-48f8-a5cc-f745e15eee43
moveTo() [of directories with subdirectories] on windows doesn't behave the same as it does on linux and mac. r=dougt, sr=bienvenu, a=asa
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@119916 18797224-902f-48f8-a5cc-f745e15eee43
r=mkaply, sr=blizzard, a=roc+moz
OS/2 only - from Jessica Blanco - different way to allocate printer data to fix crash/hang on some drivers
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@119864 18797224-902f-48f8-a5cc-f745e15eee43
r=mkaply, sr=blizzard, a=roc+moz
OS/2 only - from Javier Pedemonte - implement ConstrainPosition
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@119862 18797224-902f-48f8-a5cc-f745e15eee43
r=pedemont, sr=blizzard, a=roc+moz
OS/2 only - convert filtername to platform specific charset
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@119859 18797224-902f-48f8-a5cc-f745e15eee43
xpis can be triggered from urls with query strings
118216 - r=syd sr=dveditz a=scc adt=putterman
avoid edge case crashes by adding a few error checks
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@119812 18797224-902f-48f8-a5cc-f745e15eee43
instead of acting non-existent in the message.
r=ducarroz
sr=bienvenu
a=scc
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@119770 18797224-902f-48f8-a5cc-f745e15eee43
r=pedemont, sr=blizzard, a=asa
OS/2 only - remove unnecessary XP_OS2 chunk that tries to fix form element fonts
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@119762 18797224-902f-48f8-a5cc-f745e15eee43
in order to workaround the converter problem (bug 138578),
bug 120728, r=ducarroz, sr=sspitzer, a=rjesup@wgate.com, adt.
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@119761 18797224-902f-48f8-a5cc-f745e15eee43
r=cls, a=scc
OS/2 only - remove high performance timer code - switch to OS millisecond timers
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@119760 18797224-902f-48f8-a5cc-f745e15eee43
check existing charset source and send notification only when existing charset source is
lower than meta charset.
r=ftang, sr=jst, a=shaver, adt
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@119663 18797224-902f-48f8-a5cc-f745e15eee43
r=mkaply, sr=blizzard, a=shaver
OS/2 only - code from Javier Pedemonte to properly set font heights
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@119626 18797224-902f-48f8-a5cc-f745e15eee43
it back when leaving Print Preview
Bug 136785 r=dcone sr=attinasi adt=putterman
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@119536 18797224-902f-48f8-a5cc-f745e15eee43
Case of first letter in text labels is sometimes wrong in the Media tab
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@119499 18797224-902f-48f8-a5cc-f745e15eee43
The idea is that when the SelectAreaFrame (which is the parent) of the options
is asked to paint then it asks the ListControlframe to paint the focus ring in
the correct spot. It need to find the first non-disabled option (ignoring opt
groups) and if nothing is selected it need to find the first frame which is the
dummy option. Also, it now track thru a static data member which listControl
frame currently has focus (this was taking from how comboboxes track it internally)
Bug 64165 r=jkeiser sr=attinasi adt=jaime
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@119486 18797224-902f-48f8-a5cc-f745e15eee43
to never go away.
Bug #135753 --> figure out the folder to select when the user clicks on the
animated alert to ensure that we select the right folder.
Bug #123104 --> fix an inaccuracy in the new mail count. Always reset to 0
if we discover we have no new mail even if the state has already been changed
that way.
r=naving, sr=bienvenu/sspitzer
a=asa
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@119471 18797224-902f-48f8-a5cc-f745e15eee43
r=mkaply, sr=blizzard, a=rjesup@wgate.com
OS/2 only - workaround for MINCHO font bug
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@119422 18797224-902f-48f8-a5cc-f745e15eee43
data: protocol doesn't unescape its uri string
also fixes bug where data: urls w/o mimetype didn't work (e.g. data:,foobar)
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@119404 18797224-902f-48f8-a5cc-f745e15eee43
- Moved MoveChildrenTo() and GetRealFrame() to a point in the
file where they could be called from my new utility method
AdjustOutOfFlowFrameParentPtrs().
- Modified MoveChildrenTo() to take an nsFrameConstructorState arg,
so that it can call my new method AdjustOutOfFlowFrameParentPtrs()
so that out-of-flow floater frames are reparented to the correct
containing block when the placeholder is moved under the block
created in ConstructInline().
r=attinasi@netscape.comsr=waterson@netscape.comadt=jaimejr@netscape.coma=rjesup@wgate.com
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@119395 18797224-902f-48f8-a5cc-f745e15eee43
- Modified GetSelectionRegionRectAndScrollableView() to clip
aRect so that it is completely within the bounds of the
scrolledView. This insures that other scrolled views in
the parent hierarchy will not scroll more than they have to.
r=brade@netscape.comsr=sfraser@netscape.comadt=jaimejr@netscape.coma=asa@mozilla.org
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@119394 18797224-902f-48f8-a5cc-f745e15eee43
r=dmose r=cls a=asa (for build bustage checkin and on behalf of drivers)
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@119299 18797224-902f-48f8-a5cc-f745e15eee43
Also fixes some other S/Mime issues, as described in the bug.
r=ddrinan/ducarroz/darin sr=alecf a=rjesup
Fixing bustage, approval for checkin to the closed tree from asasaki
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@119238 18797224-902f-48f8-a5cc-f745e15eee43
Also fixes some other S/Mime issues, as described in the bug.
r=ddrinan/ducarroz/darin sr=alecf a=rjesup
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@119230 18797224-902f-48f8-a5cc-f745e15eee43
reflowed. So if a frameset frame's root frame is zero height then we mark it
hidden and not to be printed.
Bug 134769 r=dcone sr=attinasi adt=jaime
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@119221 18797224-902f-48f8-a5cc-f745e15eee43
replace default "default char" from '?' to '_'. The former one is not
acceptable in windows filename.
r=ftang, sr=alecf, a=asa, adt
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@119212 18797224-902f-48f8-a5cc-f745e15eee43
focus model is "focus follows mouse". Until we figure that out (see #137698),
we need to disable this performance trick on unix.
APPROVED FOR THE CLOSED 1.0 BRANCH.
r/sr=bienvenu, a=asa,leaf, adt=jaime
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@119163 18797224-902f-48f8-a5cc-f745e15eee43
reflowed. So if a frameset frame's root frame is zero height then we mark it
hidden and not to be printed.
Bug 134769 r=dcone sr=attinasi adt=jaime
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@119152 18797224-902f-48f8-a5cc-f745e15eee43
install Carbon Input Text event handler for embedding project
from trunk
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@119039 18797224-902f-48f8-a5cc-f745e15eee43
from trunk. add implementation to deal with Carboneevnt for input method
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@119034 18797224-902f-48f8-a5cc-f745e15eee43
All these changes should be OpenVMS only.
b=136884 r=rods sr=attinasi a=asa
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@118924 18797224-902f-48f8-a5cc-f745e15eee43
This patch is contributed by Michael Kaply <mkaply@us.ibm.com>.
Modified files: _os2 os2cv.c os2vacpp.asm
Tag: MOZILLA_1_0_0_BRANCH
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@118815 18797224-902f-48f8-a5cc-f745e15eee43
a=rjesup@wgate.com for check into the mozilla 1.0.0 branch.
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@118773 18797224-902f-48f8-a5cc-f745e15eee43
Added SuppressEventHandlers() utility routine, which PreDestroy()
and CreateAnonymousContent() now call to determine if the controller
unregister/register code should be executed.
r=rods@netscape.comsr=sfraser@netscape.comadt=jaimejr@netscape.coma=asa@mozilla.org
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@118754 18797224-902f-48f8-a5cc-f745e15eee43
in which <br> tags within <pre> blocks are translated to newlines.
r=nhotta,ducarroz,tmutreja sr=sspitzer a=rjesup adt1.0.0+
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@118673 18797224-902f-48f8-a5cc-f745e15eee43
r=wtc, a=asa
OS/2 only - don't set priority if it is the default
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_0_BRANCH@118669 18797224-902f-48f8-a5cc-f745e15eee43
will tell you what has been changed in the last week.
10/12/99 The CHANGES file is now obsolete! There is a new file called
checksetup.pl. You should get in the habit of running that file every time
you update your installation of Bugzilla. That file will be constantly
updated to automatically update your installation to match any code changes.
If you're curious as to what is going on, changes are commented in that file,
at the end.
Many thanks to Holger Schurig <holgerschurig@nikocity.de> for writing this
script!
10/11/99 Restructured voting database to add a cached value in each
bug recording how many total votes that bug has. While I'm at it, I
removed the unused "area" field from the bugs database. It is
distressing to realize that the bugs table has reached the maximum
number of indices allowed by MySQL (16), which may make future
enhancements awkward.
You must feed the following to MySQL:
alter table bugs drop column area;
alter table bugs add column votes mediumint not null, add index (votes);
You then *must* delete the data/versioncache file when you make this
change, as it contains references to the "area" field. Deleting it is safe,
bugzilla will correctly regenerate it.
If you have been using the voting feature at all, then you will then
need to update the voting cache. You can do this by visiting the
sanitycheck.cgi page, and taking it up on its offer to rebuild the
votes stuff.
10/7/99 Added voting ability. You must run the new script
"makevotestable.sh". You must also feed the following to mysql:
alter table products add column votesperuser smallint not null;
9/15/99 Apparently, newer alphas of MySQL won't allow you to have
"when" as a column name. So, I have had to rename a column in the
bugs_activity table. You must feed the below to mysql or you won't
work at all.
alter table bugs_activity change column when bug_when datetime not null;
8/16/99 Added "OpenVMS" to the list of OS's. Feed this to mysql:
alter table bugs change column op_sys op_sys enum("All", "Windows 3.1", "Windows 95", "Windows 98", "Windows NT", "Mac System 7", "Mac System 7.5", "Mac System 7.6.1", "Mac System 8.0", "Mac System 8.5", "Mac System 8.6", "AIX", "BSDI", "HP-UX", "IRIX", "Linux", "FreeBSD", "OSF/1", "Solaris", "SunOS", "Neutrino", "OS/2", "BeOS", "OpenVMS", "other") not null;
6/22/99 Added an entry to the attachments table to record who the submitter
was. Nothing uses this yet, but it still should be recorded.
alter table attachments add column submitter_id mediumint not null;
You should also run this script to populate the new field:
#!/usr/bonsaitools/bin/perl -w
use diagnostics;
use strict;
require "globals.pl";
$|=1;
ConnectToDatabase();
SendSQL("select bug_id, attach_id from attachments order by bug_id");
my @list;
while (MoreSQLData()) {
my @row = FetchSQLData();
push(@list, \@row);
}
foreach my $ref (@list) {
my ($bug, $attach) = (@$ref);
SendSQL("select long_desc from bugs where bug_id = $bug");
my $comment = FetchOneColumn() . "Created an attachment (id=$attach)";
if ($comment =~ m@-* Additional Comments From ([^ ]*)[- 0-9/:]*\nCreated an attachment \(id=$attach\)@) {
print "Found $1\n";
SendSQL("select userid from profiles where login_name=" .
SqlQuote($1));
my $userid = FetchOneColumn();
if (defined $userid && $userid > 0) {
SendSQL("update attachments set submitter_id=$userid where attach_id = $attach");
}
} else {
print "Bug $bug can't find comment for attachment $attach\n";
}
}
6/14/99 Added "BeOS" to the list of OS's. Feed this to mysql:
alter table bugs change column op_sys op_sys enum("All", "Windows 3.1", "Windows 95", "Windows 98", "Windows NT", "Mac System 7", "Mac System 7.5", "Mac System 7.6.1", "Mac System 8.0", "Mac System 8.5", "Mac System 8.6", "AIX", "BSDI", "HP-UX", "IRIX", "Linux", "FreeBSD", "OSF/1", "Solaris", "SunOS", "Neutrino", "OS/2", "BeOS", "other") not null;
5/27/99 Added support for dependency information. You must run the new
"makedependenciestable.sh" script. You can turn off dependencies with the new
"usedependencies" param, but it defaults to being on. Also, read very
carefully the description for the new "webdotbase" param; you will almost
certainly need to tweak it.
5/24/99 Added "Mac System 8.6" and "Neutrino" to the list of OS's.
Feed this to mysql:
alter table bugs change column op_sys op_sys enum("All", "Windows 3.1", "Windows 95", "Windows 98", "Windows NT", "Mac System 7", "Mac System 7.5", "Mac System 7.6.1", "Mac System 8.0", "Mac System 8.5", "Mac System 8.6", "AIX", "BSDI", "HP-UX", "IRIX", "Linux", "FreeBSD", "OSF/1", "Solaris", "SunOS", "Neutrino", "OS/2", "other") not null;
5/12/99 Added a pref to control how much email you get. This needs a new
column in the profiles table, so feed the following to mysql:
alter table profiles add column emailnotification enum("ExcludeSelfChanges", "CConly", "All") not null default "ExcludeSelfChanges";
5/5/99 Added the ability to search by creation date. To make this perform
well, you ought to do the following:
alter table bugs change column creation_ts creation_ts datetime not null, add index (creation_ts);
4/30/99 Added a new severity, "blocker". To get this into your running
Bugzilla, do the following:
alter table bugs change column bug_severity bug_severity enum("blocker", "critical", "major", "normal", "minor", "trivial", "enhancement") not null;
4/22/99 There was a bug where the long descriptions of bugs had a variety of
newline characters at the end, depending on the operating system of the browser
that submitted the text. This bug has been fixed, so that no further changes
like that will happen. But to fix problems that have already crept into your
database, you can run the following perl script (which is slow and ugly, but
does work:)
#!/usr/bonsaitools/bin/perl -w
use diagnostics;
use strict;
require "globals.pl";
$|=1;
ConnectToDatabase();
SendSQL("select bug_id from bugs order by bug_id");
my @list;
while (MoreSQLData()) {
push(@list, FetchOneColumn());
}
foreach my $id (@list) {
if ($id % 50 == 0) {
print "\n$id ";
}
SendSQL("select long_desc from bugs where bug_id = $id");
my $comment = FetchOneColumn();
my $orig = $comment;
$comment =~ s/\r\n/\n/g; # Get rid of windows-style line endings.
$comment =~ s/\r/\n/g; # Get rid of mac-style line endings.
if ($comment ne $orig) {
SendSQL("update bugs set long_desc = " . SqlQuote($comment) .
" where bug_id = $id");
print ".";
} else {
print "-";
}
}
4/8/99 Added ability to store patches with bugs. This requires a new table
to store the data, so you will need to run the "makeattachmenttable.sh" script.
3/25/99 Unfortunately, the HTML::FromText CPAN module had too many bugs, and
so I had to roll my own. We no longer use the HTML::FromText CPAN module.
3/24/99 (This entry has been removed. It used to say that we required the
HTML::FromText CPAN module, but that's no longer true.)
3/22/99 Added the ability to query by fields which have changed within a date
range. To make this perform a bit better, we need a new index:
alter table bugs_activity add index (field);
3/10/99 Added 'groups' stuff, where we have different group bits that we can
put on a person or on a bug. Some of the group bits control access to bugzilla
features. And a person can't access a bug unless he has every group bit set
that is also set on the bug. See the comments in makegroupstable.sh for a bit
more info.
The 'maintainer' param is now used only as an email address for people to send
complaints to. The groups table is what is now used to determine permissions.
You will need to run the new script "makegroupstable.sh". And then you need to
feed the following lines to MySQL (replace XXX with the login name of the
maintainer, the person you wish to be all-powerful).
alter table bugs add column groupset bigint not null;
alter table profiles add column groupset bigint not null;
update profiles set groupset=0x7fffffffffffffff where login_name = XXX;
3/8/99 Added params to control how priorities are set in a new bug. You can
now choose whether to let submitters of new bugs choose a priority, or whether
they should just accept the default priority (which is now no longer hardcoded
to "P2", but is instead a param.) The default value of the params will cause
the same behavior as before.
3/3/99 Added a "disallownew" field to the products table. If non-zero, then
don't let people file new bugs against this product. (This is for when a
product is retired, but you want to keep the bug reports around for posterity.)
Feed this to MySQL:
alter table products add column disallownew tinyint not null;
2/8/99 Added FreeBSD to the list of OS's. Feed this to MySQL:
alter table bugs change column op_sys op_sys enum("All", "Windows 3.1", "Windows 95", "Windows 98", "Windows NT", "Mac System 7", "Mac System 7.5", "Mac System 7.6.1", "Mac System 8.0", "Mac System 8.5", "AIX", "BSDI", "HP-UX", "IRIX", "Linux", "FreeBSD", "OSF/1", "Solaris", "SunOS", "OS/2", "other") not null;
2/4/99 Added a new column "description" to the components table, and added
links to a new page which will use this to describe the components of a
given product. Feed this to MySQL:
alter table components add column description mediumtext not null;
2/3/99 Added a new column "initialqacontact" to the components table that gives
an initial QA contact field. It may be empty if you wish the initial qa
contact to be empty. If you're not using the QA contact field, you don't need
to add this column, but you might as well be safe and add it anyway:
alter table components add column initialqacontact tinytext not null;
2/2/99 Added a new column "milestoneurl" to the products table that gives a URL
which is to describe the currently defined milestones for a product. If you
don't use target milestone, you might be able to get away without adding this
column, but you might as well be safe and add it anyway:
alter table products add column milestoneurl tinytext not null;
1/29/99 Whoops; had a misspelled op_sys. It was "Mac System 7.1.6"; it should
be "Mac System 7.6.1". It turns out I had no bugs with this value set, so I
could just do the below simple command. If you have bugs with this value, you
may need to do something more complicated.
alter table bugs change column op_sys op_sys enum("All", "Windows 3.1", "Windows 95", "Windows 98", "Windows NT", "Mac System 7", "Mac System 7.5", "Mac System 7.6.1", "Mac System 8.0", "Mac System 8.5", "AIX", "BSDI", "HP-UX", "IRIX", "Linux", "OSF/1", "Solaris", "SunOS", "OS/2", "other") not null;
1/20/99 Added new fields: Target Milestone, QA Contact, and Status Whiteboard.
These fields are all optional in the UI; there are parameters to turn them on.
However, whether or not you use them, the fields need to be in the DB. There
is some code that needs them, even if you don't.
To update your DB to have these fields, send the following to MySQL:
alter table bugs add column target_milestone varchar(20) not null,
add column qa_contact mediumint not null,
add column status_whiteboard mediumtext not null,
add index (target_milestone), add index (qa_contact);
1/18/99 You can now query by CC. To make this perform reasonably, the CC table
needs some indices. The following MySQL does the necessary stuff:
alter table cc add index (bug_id), add index (who);
1/15/99 The op_sys field can now be queried by (and more easily tweaked).
To make this perform reasonably, it needs an index. The following MySQL
command will create the necessary index:
alter table bugs add index (op_sys);
12/2/98 The op_sys and rep_platform fields have been tweaked. op_sys
is now an enum, rather than having the legal values all hard-coded in
perl. rep_platform now no longer allows a value of "X-Windows".
Here's how I ported to the new world. This ought to work for you too.
Actually, it's probably overkill. I had a lot of illegal values for op_sys
in my tables, from importing bugs from strange places. If you haven't done
anything funky, then much of the below will be a no-op.
First, send the following commands to MySQL to make sure all your values for
rep_platform and op_sys are legal in the new world..
update bugs set rep_platform="Sun" where rep_platform="X-Windows" and op_sys like "Solaris%";
update bugs set rep_platform="SGI" where rep_platform="X-Windows" and op_sys = "IRIX";
update bugs set rep_platform="SGI" where rep_platform="X-Windows" and op_sys = "HP-UX";
update bugs set rep_platform="DEC" where rep_platform="X-Windows" and op_sys = "OSF/1";
update bugs set rep_platform="PC" where rep_platform="X-Windows" and op_sys = "Linux";
update bugs set rep_platform="other" where rep_platform="X-Windows";
update bugs set rep_platform="other" where rep_platform="";
update bugs set op_sys="Mac System 7" where op_sys="System 7";
update bugs set op_sys="Mac System 7.5" where op_sys="System 7.5";
update bugs set op_sys="Mac System 8.0" where op_sys="8.0";
update bugs set op_sys="OSF/1" where op_sys="Digital Unix 4.0";
update bugs set op_sys="IRIX" where op_sys like "IRIX %";
update bugs set op_sys="HP-UX" where op_sys like "HP-UX %";
update bugs set op_sys="Windows NT" where op_sys like "NT %";
update bugs set op_sys="OSF/1" where op_sys like "OSF/1 %";
update bugs set op_sys="Solaris" where op_sys like "Solaris %";
update bugs set op_sys="SunOS" where op_sys like "SunOS%";
update bugs set op_sys="other" where op_sys = "Motif";
update bugs set op_sys="other" where op_sys = "Other";
Next, send the following commands to make sure you now have only legal
entries in your table. If either of the queries do not come up empty, then
you have to do more stuff like the above.
select bug_id,op_sys,rep_platform from bugs where rep_platform not regexp "^(All|DEC|HP|Macintosh|PC|SGI|Sun|X-Windows|Other)$";
select bug_id,op_sys,rep_platform from bugs where op_sys not regexp "^(All|Windows 3.1|Windows 95|Windows 98|Windows NT|Mac System 7|Mac System 7.5|Mac System 7.1.6|Mac System 8.0|AIX|BSDI|HP-UX|IRIX|Linux|OSF/1|Solaris|SunOS|other)$";
Finally, once that's all clear, alter the table to make enforce the new legal
entries:
alter table bugs change column op_sys op_sys enum("All", "Windows 3.1", "Windows 95", "Windows 98", "Windows NT", "Mac System 7", "Mac System 7.5", "Mac System 7.1.6", "Mac System 8.0", "AIX", "BSDI", "HP-UX", "IRIX", "Linux", "OSF/1", "Solaris", "SunOS", "other") not null, change column rep_platform rep_platform enum("All", "DEC", "HP", "Macintosh", "PC", "SGI", "Sun", "Other");
11/20/98 Added searching of CC field. To better support this, added
some indexes to the CC table. You probably want to execute the following
mysql commands:
alter table cc add index (bug_id);
alter table cc add index (who);
10/27/98 security check for legal products in place. bug charts are not
available as an option if collectstats.pl has never been run. all products
get daily stats collected now. README updated: Chart::Base is listed as
a requirement, instructions for using collectstats.pl included as
an optional step. also got silly and added optional quips to bug
<p>Simply put, the more effectively you report a bug, the more
likely an engineer will actually fix it.</p>
<p>These guidelines are a general
tutorial to teach novice and intermediate bug reporters how to compose effective bug reports. Not every sentence may precisely apply to
your software project.</p>
</blockquote>
<h3>How to Write a Useful Bug Report</h3>
<blockquote>
<p>Useful bug reports are ones that get bugs fixed. A useful bug
report normally has two qualities:</p>
<ol>
<li><b>Reproducible.</b> If an engineer can't see the bug herself to prove that it exists, she'll probably stamp your bug report "WORKSFORME" or "INVALID" and move on to the next bug. Every detail you can provide helps.<br>
<br>
</li>
<li><b>Specific.</b> The quicker the engineer can isolate the bug
to a specific area, the more likely she'll expediently fix it.
(If a programmer or tester has to decypher a bug, they may spend
more time cursing the submitter than solving the problem.)
<br>
<br>
[ <ahref="#tips"name="Anchor">Tell Me More</a> ]
</li>
</ol>
<p>Let's say the application you're testing is a web browser. You
crash at foo.com, and want to write up a bug report:</p>
<blockquote>
<p><b>BAD:</b> "My browser crashed. I think I was on www.foo.com. I play golf with Bill Gates, so you better fix this problem, or I'll report you to him. By the way, your Back icon looks like a squashed rodent. UGGGLY. And my grandmother's home page is all messed up in your browser. Thx 4 UR help."
</p>
<p>
<b>GOOD:</b> "I crashed each time I went to www.foo.com, using
the 2002-02-25 build on a Windows 2000 system. I also
rebooted into Linux, and reproduced this problem using the 2002-02-24
Linux build.
</p>
<p>
It again crashed each time upon drawing the Foo banner at the top
of the page. I broke apart the page, and discovered that the
following image link will crash the application reproducibly,
<h3>How to Enter your Useful Bug Report into Bugzilla:</h3>
<blockquote>
<p>Before you enter your bug, use Bugzilla's
<ahref="query.cgi">search page</a> to determine whether the defect you've discovered is a known, already-reported bug. If your bug is the 37th duplicate of a known issue, you're more likely to annoy the engineer. (Annoyed
engineers fix fewer bugs.)
</p>
<p>
Next, be sure to reproduce your bug using a recent
build. Engineers tend to be most interested in problems affecting
the code base that they're actively working on. After all, the bug you're reporting
may already be fixed.
</p>
<p>
If you've discovered a new bug using a current build, report it in
Bugzilla:
</p>
<ol>
<li>From your Bugzilla main page, choose
"<ahref="enter_bug.cgi">Enter a new bug</a>".</li>
<li>Select the product that you've found a bug in.</li>
<li>Enter your e-mail address, password, and press the "Login"
button. (If you don't yet have a password, leave the password field empty,
and press the "E-mail me a password" button instead.
You'll quickly receive an e-mail message with your password.)</li>
</ol>
<p>Now, fill out the form. Here's what it all means:</p>
<p><b>Where did you find the bug?</b></p>
<blockquote>
<p><b>Product: In which product did you find the bug?</b><br>
You just specified this on the last page, so you can't edit it here.</p>
<p><b>Version: In which product version did you find the
bug?</b><br>
(If applicable)</p>
<p><b>Component: In which component does the bug exist?</b><br>
Bugzilla requires that you select a component to enter a bug. (Not sure which to choose?
Click on the Component link. You'll see a description of each component, to help you make the best choice.)</p>
<p><b>OS: On which Operating System (OS) did you find this bug?</b>
(e.g. Linux, Windows 2000, Mac OS 9.)<br>
If you know the bug happens on all OSs, choose 'All'. Otherwise,
select the OS that you found the bug on, or "Other" if your OS
isn't listed.</p>
</blockquote>
<p><b>How important is the bug?</b></p>
<blockquote>
<p><b>Severity: How damaging is the bug?</b><br>
This item defaults to 'normal'. If you're not sure what severity your bug deserves, click on the Severity link.
You'll see a description of each severity rating. <br>
</p>
</blockquote>
<p><b>Who will be following up on the bug?</b></p>
<blockquote>
<p><b>Assigned To: Which engineer should be responsible for fixing
this bug?</b><br>
Bugzilla will automatically assign the bug to a default engineer
upon submitting a bug report. If you'd prefer to directly assign the bug to
someone else, enter their e-mail address into this field. (To see the list of
default engineers for each component, click on the Component
link.)</p>
<p><b>Cc: Who else should receive e-mail updates on changes to this
bug?</b><br>
List the full e-mail addresses of other individuals who should
receive an e-mail update upon every change to the bug report. You
can enter as many e-mail addresses as you'd like, separated by spaces or commas, as long as those
people have Bugzilla accounts.</p>
</blockquote>
<p><b>What else can you tell the engineer about the bug?</b></p>
<blockquote>
<p><b>Summary:</b><b>How would you describe the bug, in
approximately 60 or fewer characters?</b><br>
A good summary should <b>quickly and uniquely identify a bug
report</b>. Otherwise, an engineer cannot meaningfully identify
your bug by its summary, and will often fail to pay attention to
your bug report when skimming through a 10 page bug list.<br>
<br>
A useful summary might be
"<tt>PCMCIA install fails on Tosh Tecra 780DVD w/ 3c589C</tt>".
"<tt>Software fails</tt>" or "<tt>install problem</tt>" would be
examples of a bad summary.<br>
<br>
[ <ahref="#summary">Tell Me More</a> ]<br>
<br>
<b>Description: </b><br>
Please provide a detailed problem report in this field.
Your bug's recipients will most likely expect the following information:</p>
<blockquote>
<p><b>Overview Description:</b> More detailed expansion of
summary.</p>
<blockquote>
<pre>
Drag-selecting any page crashes Mac builds in NSGetFactory
</pre>
</blockquote>
<p><b>Steps to Reproduce:</b> Minimized, easy-to-follow steps that will
trigger the bug. Include any special setup steps.</p>
<blockquote>
<pre>
1) View any web page. (I used the default sample page,
resource:/res/samples/test0.html)
2) Drag-select the page. (Specifically, while holding down
the mouse button, drag the mouse pointer downwards from any
point in the browser's content region to the bottom of the
browser's content region.)
</pre>
</blockquote>
<p>
<b>Actual Results:</b> What the application did after performing
the above steps.
</p>
<blockquote>
<pre>
The application crashed. Stack crawl appended below from MacsBug.
</pre>
</blockquote>
<p><b>Expected Results:</b> What the application should have done,
were the bug not present.</p>
<blockquote>
<pre>
The window should scroll downwards. Scrolled content should be selected.
(Or, at least, the application should not crash.)
</pre>
</blockquote>
<p><b>Build Date & Platform:</b> Date and platform of the build
that you first encountered the bug in.</p>
<blockquote>
<pre>
Build 2002-03-15 on Mac OS 9.0
</pre>
</blockquote>
<p><b>Additional Builds and Platforms:</b> Whether or not the bug
takes place on other platforms (or browsers, if applicable).</p>
<blockquote>
<pre>
- Also Occurs On
Mozilla (2002-03-15 build on Windows NT 4.0)
- Doesn't Occur On
Mozilla (2002-03-15 build on Red Hat Linux; feature not supported)
Internet Explorer 5.0 (shipping build on Windows NT 4.0)
Netscape Communicator 4.5 (shipping build on Mac OS 9.0)
</pre>
</blockquote>
<p><b>Additional Information:</b> Any other debugging information.
For crashing bugs:</p>
<ul>
<li><b>Win32:</b> if you receive a Dr. Watson error, please note
the type of the crash, and the module that the application crashed
in. (e.g. access violation in apprunner.exe)</li>
<li><b>Mac OS:</b> if you're running MacsBug, please provide the
results of a <b>how</b> and an <b>sc</b>:</li>
</ul>
<blockquote>
<pre>
*** MACSBUG STACK CRAWL OF CRASH (Mac OS)
Calling chain using A6/R1 links
Back chain ISA Caller
00000000 PPC 0BA85E74
03AEFD80 PPC 0B742248
03AEFD30 PPC 0B50FDDC NSGetFactory+027FC
PowerPC unmapped memory exception at 0B512BD0 NSGetFactory+055F0
</pre>
</blockquote>
</blockquote>
</blockquote>
<p>You're done!<br>
<br>
After double-checking your entries for any possible errors, press
the "Commit" button, and your bug report will now be in the
Bugzilla database.<br>
</p>
</blockquote>
<hr>
<h3>More Information on Writing Good Bugs</h3>
<blockquote>
<p><b><aname="tips"></a> 1. General Tips for a Useful Bug
Report</b>
</p>
<blockquote>
<p>
<b>Use an explicit structure, so your bug reports are easy to
skim.</b> Bug report users often need immediate access to specific
sections of your bug. If your Bugzilla installation supports the
Bugzilla Helper, use it.
</p>
<p>
<b>Avoid cuteness if it costs clarity.</b> Nobody will be laughing
at your funny bug title at 3:00 AM when they can't remember how to
find your bug.
</p>
<p>
<b>One bug per report.</b> Completely different people typically
fix, verify, and prioritize different bugs. If you mix a handful of
bugs into a single report, the right people probably won't discover
your bugs in a timely fashion, or at all. Certain bugs are also
more important than others. It's impossible to prioritize a bug
report when it contains four different issues, all of differing
importance.
</p>
<p>
<b>No bug is too trivial to report.</b> Unless you're reading the
source code, you can't see actual software bugs, like a dangling
pointer -- you'll see their visible manifestations, such as the
segfault when the application finally crashes. Severe software
problems can manifest themselves in superficially trivial ways.
File them anyway.<br>
</p>
</blockquote>
<p><b><aname="summary"></a>2. How and Why to Write Good Bug Summaries</b>
</p>
<blockquote>
<p><b>You want to make a good first impression on the bug
recipient.</b> Just like a New York Times headline guides readers
towards a relevant article from dozens of choices, will your bug summary
suggest that your bug report is worth reading from dozens or hundreds of
choices?
</p>
<p>
Conversely, a vague bug summary like <tt>install problem</tt> forces anyone
reviewing installation bugs to waste time opening up your bug to
determine whether it matters.
</p>
<p>
<b>Your bug will often be searched by its summary.</b> Just as
you'd find web pages with Google by searching by keywords through
intuition, so will other people locate your bugs. Descriptive bug
summaries are naturally keyword-rich, and easier to find.
</p>
<p>
For example, you'll find a bug titled "<tt>Dragging icons from List View to
gnome-terminal doesn't paste path</tt>" if you search on "List",
"terminal", or "path". Those search keywords wouldn't have found a
bug titled "<tt>Dragging icons
doesn't paste</tt>".
</p>
<p>
Ask yourself, "Would someone understand my bug from just this
summary?" If so, you've written a fine summary.
</p>
<p><b>Don't write titles like these:</b></p>
<ol>
<li>"Can't install" - Why can't you install? What happens when you
try to install?</li>
<li>"Severe Performance Problems" - ...and they occur when you do
what?</li>
<li>"back button does not work" - Ever? At all?</li>
</ol>
<p><b>Good bug titles:</b></p>
<ol>
<li>"1.0 upgrade installation fails if Mozilla M18 package present"
- Explains problem and the context.</li>
<li>"RPM 4 installer crashes if launched on Red Hat 6.2 (RPM 3)
system" - Explains what happens, and the context.</li>
</ol>
</blockquote>
</blockquote>
<p>(Written and maintained by
<ahref="http://www.prometheus-music.com/eli">Eli Goldberg</a>. Claudius
Gayle, Gervase Markham, Peter Mock, Chris Pratt, Tom Schutter and Chris Yeh also
delete$::param{'version'};# Don't write the version number out to
# the params file.
printFIDGenerateCode('%::param');
$::param{'version'}=$v;
printFID"1;\n";
closeFID;
rename$tmpname,"data/params"||die"Can't rename $tmpname to data/params";
ChmodDataFile('data/params',0666);
}
subDefParam{
my($id,$desc,$type,$default,$checker)=(@_);
push@::param_list,$id;
$::param_desc{$id}=$desc;
$::param_type{$id}=$type;
$::param_default{$id}=$default;
if(defined$checker){
$::param_checker{$id}=$checker;
}
}
subcheck_numeric{
my($value)=(@_);
if($value!~/^[0-9]+$/){
return"must be a numeric value";
}
return"";
}
subcheck_shadowdb{
my($value)=(@_);
$value=trim($value);
if($valueeq""){
return"";
}
SendSQL("SHOW DATABASES");
while(MoreSQLData()){
my$n=FetchOneColumn();
if(lc($n)eqlc($value)){
return"The $n database already exists. If that's really the name you want to use for the backup, please CAREFULLY make the existing database go away somehow, and then try again.";
}
}
SendSQL("CREATE DATABASE $value");
SendSQL("INSERT INTO shadowlog (command) VALUES ('SYNCUP')",1);
return"";
}
@::param_list=();
# OK, here are the definitions themselves.
#
# The type of parameters (the third parameter to DefParam) can be one
# of the following:
#
# t -- A short text entry field (suitable for a single line)
# l -- A long text field (suitable for many lines)
# b -- A boolean value (either 1 or 0)
DefParam("maintainer",
"The email address of the person who maintains this installation of Bugzilla.",
"t",
'THE MAINTAINER HAS NOT YET BEEN SET');
DefParam("urlbase",
"The URL that is the common initial leading part of all Bugzilla URLs. Must end with a / character.",
return"must be a legal URL, that starts with http and ends with a slash.";
}
return"";
}
DefParam("cookiepath",
"Directory path under your document root that holds your Bugzilla installation. Make sure to begin with a /.",
"t",
"/");
DefParam("usequip",
"If this is on, Bugzilla displays a silly quip at the beginning of buglists, and lets users add to the list of quips.",
"b",
1);
# Added parameter - dkl, 5/28/02
DefParam("usetransactions",
"If this is on, Bugzilla will enable transaction support (currently PostgreSQL only).",
"b",
0);
DefParam("shadowdb",
"If non-empty, then this is the name of another database in which Bugzilla will keep a shadow read-only copy of everything. This is done so that long slow read-only operations can be used against this db, and not lock up things for everyone else. Turning on this parameter will create the given database; be careful not to use the name of an existing database with useful data in it!",
"t",
"",
\&check_shadowdb);
DefParam("queryagainstshadowdb",
"If this is on, and the shadowdb is set, then queries will happen against the shadow database.",
"b",
0);
# Adding in four parameters for LDAP authentication. -JMR, 7/28/00
DefParam("useLDAP",
"Turn this on to use an LDAP directory for user authentication ".
"instead of the Bugzilla database. (User profiles will still be ".
"stored in the database, and will match against the LDAP user by ".
"email address.)",
"b",
0);
DefParam("LDAPserver",
"The name (and optionally port) of your LDAP server. (e.g. ldap.company.com, or ldap.company.com:portnum)",
"t",
"");
DefParam("LDAPBaseDN",
"The BaseDN for authenticating users against. (e.g. \"ou=People,o=Company\")",
"t",
"");
DefParam("LDAPmailattribute",
"The name of the attribute of a user in your directory that ".
"contains the email address.",
"t",
"mail");
#End of LDAP parameters
DefParam("mostfreqthreshold",
"The minimum number of duplicates a bug needs to show up on the <A HREF=\"duplicates.cgi\">most frequently reported bugs page</a>. If you have a large database and this page takes a long time to load, try increasing this number.",
"t",
"2");
DefParam("mybugstemplate",
"This is the URL to use to bring up a simple 'all of my bugs' list for a user. %userid% will get replaced with the login name of a user.",
"If this field is non-empty, then Bugzilla will be completely disabled and this text will be displayed instead of all the Bugzilla pages.",
"l",
"");
DefParam("sendmailnow",
"If this is on, Bugzilla will tell sendmail to send any e-mail immediately. If you have a large number of users with a large amount of e-mail traffic, enabling this option may dramatically slow down Bugzilla. Best used for smaller installations of Bugzilla.",
"b",
0);
DefParam("passwordmail",
q{The email that gets sent to people to tell them their password. Within
this text, %mailaddress% gets replaced by the person's email address,
%login% gets replaced by the person's login (usually the same thing), and
%password% gets replaced by their password. %<i>anythingelse</i>% gets
replaced by the definition of that parameter (as defined on this page).},
"l",
q{From: bugzilla-daemon
To: %mailaddress%
Subject: Your Bugzilla password.
To use the wonders of Bugzilla, you can use the following:
E-mail address: %login%
Password: %password%
To change your password, go to:
%urlbase%userprefs.cgi
});
DefParam("newchangedmail",
q{The email that gets sent to people when a bug changes. Within this
text, %to% gets replaced with the e-mail address of the person recieving
the mail. %bugid% gets replaced by the bug number. %diffs% gets
replaced with what's changed. %neworchanged% is "New:" if this mail is
reporting a new bug or empty if changes were made to an existing one.
%summary% gets replaced by the summary of this bug. %reasonsheader%
is replaced by an abbreviated list of reasons why the user is getting the email,
suitable for use in an email header (such as X-Bugzilla-Reason).
%reasonsbody% is replaced by text that explains why the user is getting the email
in more user friendly text than %reasonsheader%.
%<i>anythingelse</i>% gets replaced by the definition of
that parameter (as defined on this
page).},
"l",
"From: bugzilla-daemon
To: %to%
Subject: [Bug %bugid%] %neworchanged%%summary%
X-Bugzilla-Reason: %reasonsheader%
%urlbase%show_bug.cgi?id=%bugid%
%diffs%
%reasonsbody%");
DefParam("whinedays",
"The number of days that we'll let a bug sit untouched in a NEW state before our cronjob will whine at the owner.",
"t",
7,
\&check_numeric);
DefParam("whinemail",
"The email that gets sent to anyone who has a NEW bug that hasn't been touched for more than <b>whinedays</b>. Within this text, %email% gets replaced by the offender's email address. %userid% gets replaced by the offender's bugzilla login (which, in most installations, is the same as the email address.) %<i>anythingelse</i>% gets replaced by the definition of that parameter (as defined on this page).<p> It is a good idea to make sure this message has a valid From: address, so that if the mail bounces, a real person can know that there are bugs assigned to an invalid address.",
"l",
q{From: %maintainer%
To: %email%
Subject: Your Bugzilla buglist needs attention.
[This e-mail has been automatically generated.]
You have one or more bugs assigned to you in the Bugzilla
bugsystem (%urlbase%) that require
attention.
All of these bugs are in the NEW state, and have not been touched
in %whinedays% days or more. You need to take a look at them, and
decide on an initial action.
Generally, this means one of three things:
(1) You decide this bug is really quick to deal with (like, it's INVALID),
and so you get rid of it immediately.
(2) You decide the bug doesn't belong to you, and you reassign it to someone
else. (Hint: if you don't know who to reassign it to, make sure that
the Component field seems reasonable, and then use the "Reassign bug to
owner of selected component" option.)
(3) You decide the bug belongs to you, but you can't solve it this moment.
Just use the "Accept bug" command.
To get a list of all NEW bugs, you can use this URL (bookmark it if you like!):
"If this is on, then people submitting bugs can choose an initial priority for that bug. If off, then all bugs initially have the default priority selected below.",
"b",
1);
subcheck_priority{
my($value)=(@_);
GetVersionTable();
if(lsearch(\@::legal_priority,$value)<0){
return"Must be a legal priority value: one of ".
join(", ",@::legal_priority);
}
return"";
}
DefParam("defaultpriority",
"This is the priority that newly entered bugs are set to.",
"t",
"P2",
\&check_priority);
DefParam("usetargetmilestone",
"Do you wish to use the Target Milestone field?",
"b",
0);
DefParam("nummilestones",
"If using Target Milestone, how many milestones do you wish to
appear?",
"t",
10,
\&check_numeric);
DefParam("curmilestone",
"If using Target Milestone, Which milestone are we working toward right now?",
"t",
1,
\&check_numeric);
DefParam("musthavemilestoneonaccept",
"If you are using Target Milestone, do you want to require that the milestone be set in order for a user to ACCEPT a bug?",
"b",
0);
DefParam("useqacontact",
"Do you wish to use the QA Contact field?",
"b",
0);
DefParam("usestatuswhiteboard",
"Do you wish to use the Status Whiteboard field?",
"b",
0);
DefParam("usebrowserinfo",
"Do you want bug reports to be assigned an OS & Platform based on the browser
the user makes the report from?",
"b",
1);
DefParam("usedependencies",
"Do you wish to use dependencies (allowing you to mark which bugs depend on which other ones)?",
"b",
1);
DefParam("webdotbase",
"It is possible to show graphs of dependent bugs. You may set this parameter to
any of the following:
<ul>
<li>A complete file path to \'dot\' (part of <a
href=\"http://www.graphviz.org\">GraphViz</a>) will generate the graphs
locally.</li>
<li>A URL prefix pointing to an installation of the <a
return"The file path \"$value\" is not a valid executable. Please specify the complete file path to 'dot' if you intend to generate graphs locally.";
}
# Check .htaccess allows access to generated images
if(-e"data/webdot/.htaccess"){
openHTACCESS,"data/webdot/.htaccess";
if(!grep(/png/,<HTACCESS>)){
print"Dependency graph images are not accessible.\nDelete data/webdot/.htaccess and re-run checksetup.pl to rectify.\n";
}
closeHTACCESS;
}
}
return"";
}
DefParam("expectbigqueries",
"If this is on, then we will tell mysql to <tt>set option SQL_BIG_TABLES=1</tt> before doing queries on bugs. This will be a little slower, but one will not get the error <tt>The table ### is full</tt> for big queries that require a big temporary table.",
"b",
0);
DefParam("emailregexp",
'This defines the regexp to use for legal email addresses. The default tries to match fully qualified email addresses. Another popular value to put here is <tt>^[^@]+$</tt>, which means "local usernames, no @ allowed."',
"t",
q:^[^@]+@[^@]+\\.[^@]+$:);
DefParam("emailregexpdesc",
"This describes in english words what kinds of legal addresses are allowed by the <tt>emailregexp</tt> param.",
"l",
"A legal address must contain exactly one '\@', and at least one '.' after the \@.");
DefParam("emailsuffix",
"This is a string to append to any email addresses when actually sending mail to that address. It is useful if you have changed the <tt>emailregexp</tt> param to only allow local usernames, but you want the mail to be delivered to username\@my.local.hostname.",
"t",
"");
DefParam("voteremovedmail",
q{This is a mail message to send to anyone who gets a vote removed from a bug for any reason. %to% gets replaced by the person who used to be voting for this bug. %bugid% gets replaced by the bug number. %reason% gets replaced by a short reason describing why the vote(s) were removed. %votesremoved%, %votesold% and %votesnew% is the number of votes removed, before and after respectively. %votesremovedtext%, %votesoldtext% and %votesnewtext% are these as sentences, eg "You had 2 votes on this bug." %count% is also supported for backwards compatibility. %<i>anythingelse</i>% gets replaced by the definition of that parameter (as defined on this page).},
"l",
"From: bugzilla-daemon
To: %to%
Subject: [Bug %bugid%] Some or all of your votes have been removed.
Some or all of your votes have been removed from bug %bugid%.
%votesoldtext%
%votesnewtext%
Reason: %reason%
%urlbase%show_bug.cgi?id=%bugid%
");
DefParam("allowbugdeletion",
q{The pages to edit products and components and versions can delete all associated bugs when you delete a product (or component or version). Since that is a pretty scary idea, you have to turn on this option before any such deletions will ever happen.},
"b",
0);
DefParam("allowemailchange",
q{Users can change their own email address through the preferences. Note that the change is validated by emailing both addresses, so switching this option on will not let users use an invalid address.},
"b",
0);
DefParam("allowuserdeletion",
q{The pages to edit users can also let you delete a user. But there is no code that goes and cleans up any references to that user in other tables, so such deletions are kinda scary. So, you have to turn on this option before any such deletions will ever happen.},
"b",
0);
DefParam("browserbugmessage",
"If bugzilla gets unexpected data from the browser, in addition to displaying the cause of the problem, it will output this HTML as well.",
"l",
"this may indicate a bug in your browser.\n");
#
# Parameters to force users to comment their changes for different actions.
DefParam("commentonaccept",
"If this option is on, the user needs to enter a short comment if he accepts the bug",
"b",0);
DefParam("commentonclearresolution",
"If this option is on, the user needs to enter a short comment if the bugs resolution is cleared",
"b",0);
DefParam("commentonconfirm",
"If this option is on, the user needs to enter a short comment when confirming a bug",
"b",0);
DefParam("commentonresolve",
"If this option is on, the user needs to enter a short comment if the bug is resolved",
"b",0);
DefParam("commentonreassign",
"If this option is on, the user needs to enter a short comment if the bug is reassigned",
"b",0);
DefParam("commentonreassignbycomponent",
"If this option is on, the user needs to enter a short comment if the bug is reassigned by component",
"b",0);
DefParam("commentonreopen",
"If this option is on, the user needs to enter a short comment if the bug is reopened",
"b",0);
DefParam("commentonverify",
"If this option is on, the user needs to enter a short comment if the bug is verified",
"b",0);
DefParam("commentonclose",
"If this option is on, the user needs to enter a short comment if the bug is closed",
"b",0);
DefParam("commentonduplicate",
"If this option is on, the user needs to enter a short comment if the bug is marked as duplicate",
"b",0);
DefParam("supportwatchers",
"Support one user watching (ie getting copies of all related email".
" about) another's bugs. Useful for people going on vacation, and".
" QA folks watching particular developers' bugs",
"b",0);
DefParam("move-enabled",
"If this is on, Bugzilla will allow certain people to move bugs to the defined database.",
"b",
0);
DefParam("move-button-text",
"The text written on the Move button. Explain where the bug is being moved to.",
"t",
'Move To Bugscape');
DefParam("move-to-url",
"The URL of the database we allow some of our bugs to be moved to.",
"t",
'');
DefParam("move-to-address",
"To move bugs, an email is sent to the target database. This is the email address that database
uses to listen for incoming bugs.",
"t",
'bugzilla-import');
DefParam("moved-from-address",
"To move bugs, an email is sent to the target database. This is the email address from which
this mail, and error messages are sent.",
"t",
'bugzilla-admin');
DefParam("movers",
"A list of people with permission to move bugs and reopen moved bugs (in case the move operation fails).",
"t",
'');
DefParam("moved-default-product",
"Bugs moved from other databases to here are assigned to this product.",
"t",
'');
DefParam("moved-default-component",
"Bugs moved from other databases to here are assigned to this component.",
"t",
'');
# The maximum size (in bytes) for patches and non-patch attachments.
# The default limit is 1000KB, which is 24KB less than mysql's default
# maximum packet size (which determines how much data can be sent in a
# single mysql packet and thus how much data can be inserted into the
# database) to provide breathing space for the data in other fields of
# the attachment record as well as any mysql packet overhead (I don't
# know of any, but I suspect there may be some.)
DefParam("maxpatchsize",
"The maximum size (in kilobytes) of patches. Bugzilla will not
accept patches greater than this number of kilobytes in size.
To accept patches of any size (subject to the limitations of
your server software), set this value to zero.",
"t",
'1000');
DefParam("maxattachmentsize",
"The maximum size (in kilobytes) of non-patch attachments. Bugzilla
will not accept attachments greater than this number of kilobytes
in size. To accept attachments of any size (subject to the
limitations of your server software), set this value to zero.",
CONTENT="Modular DocBook HTML Stylesheet Version 1.76b+
"><LINK
REL="HOME"
TITLE="The Bugzilla Guide"
HREF="index.html"><LINK
REL="PREVIOUS"
TITLE="Software Download Links"
HREF="downloadlinks.html"><LINK
REL="NEXT"
TITLE="Database Schema Chart"
HREF="dbschema.html"></HEAD
><BODY
CLASS="appendix"
BGCOLOR="#FFFFFF"
TEXT="#000000"
LINK="#0000FF"
VLINK="#840084"
ALINK="#0000FF"
><DIV
CLASS="NAVHEADER"
><TABLE
SUMMARY="Header navigation table"
WIDTH="100%"
BORDER="0"
CELLPADDING="0"
CELLSPACING="0"
><TR
><TH
COLSPAN="3"
ALIGN="center"
>The Bugzilla Guide</TH
></TR
><TR
><TD
WIDTH="10%"
ALIGN="left"
VALIGN="bottom"
><A
HREF="downloadlinks.html"
ACCESSKEY="P"
>Prev</A
></TD
><TD
WIDTH="80%"
ALIGN="center"
VALIGN="bottom"
></TD
><TD
WIDTH="10%"
ALIGN="right"
VALIGN="bottom"
><A
HREF="dbschema.html"
ACCESSKEY="N"
>Next</A
></TD
></TR
></TABLE
><HR
ALIGN="LEFT"
WIDTH="100%"></DIV
><DIV
CLASS="appendix"
><H1
><A
NAME="database">Appendix C. The Bugzilla Database</H1
><DIV
CLASS="TOC"
><DL
><DT
><B
>Table of Contents</B
></DT
><DT
>C.1. <A
HREF="dbschema.html"
>Database Schema Chart</A
></DT
><DT
>C.2. <A
HREF="dbdoc.html"
>MySQL Bugzilla Database Introduction</A
></DT
><DT
>C.3. <A
HREF="granttables.html"
>MySQL Permissions & Grant Tables</A
></DT
></DL
></DIV
><DIV
CLASS="note"
><P
></P
><TABLE
CLASS="note"
WIDTH="100%"
BORDER="0"
><TR
><TD
WIDTH="25"
ALIGN="CENTER"
VALIGN="TOP"
><IMG
SRC="../images/note.gif"
HSPACE="5"
ALT="Note"></TD
><TD
ALIGN="LEFT"
VALIGN="TOP"
><P
> This document really needs to be updated with more fleshed out information about primary keys, interrelationships, and maybe some nifty tables to document dependencies. Any takers?
>. Executing the following code snippet from a UNIX command shell will rectify the problem if your Bugzilla installation is intended for an English-speaking audience. As always, be sure your Bugzilla installation has a good backup before making changes, and I recommend you understand what the script is doing before executing it. </P
><P
><TABLE
BORDER="0"
BGCOLOR="#E0E0E0"
WIDTH="100%"
><TR
><TD
><FONT
COLOR="#000000"
><PRE
CLASS="programlisting"
> bash# cd $BUGZILLA_HOME; for i in `ls *.cgi`; \
do cat $i | sed 's/Content-type\: text\/html/Content-Type: text\/html\; charset=ISO-8859-1/' >$i.tmp; \
mv $i.tmp $i; done
</PRE
></FONT
></TD
></TR
></TABLE
></P
><P
> All this one-liner command does is search for all instances of
While some of the advice is Mozilla-specific, the basic principles of reporting Reproducible, Specific bugs, isolating the Product you are using, the Version of the Product, the Component which failed, the Hardware Platform, and Operating System you were using at the time of the failure go a long way toward ensuring accurate, responsible fixes for the bug that bit you.
</P
><P
> The procedure for filing a test bug is as follows:
> At the very least, ensure you password the "mysql -u root"
account and the "bugs" account, establish grant table
rights (consult the Keystone guide in Appendix C: The
Bugzilla Database for some easy-to-use details) that do
not allow CREATE, DROP, RELOAD, SHUTDOWN, and PROCESS for
user "bugs". I wrote up the Keystone advice back when I
knew far less about security than I do now : )
</P
></LI
><LI
><P
> Lock down /etc/inetd.conf. Heck, disable inet entirely on
this box. It should only listen to port 25 for Sendmail
and port 80 for Apache.
</P
></LI
><LI
><P
> Do not run Apache as <SPAN
CLASS="QUOTE"
>"nobody"</SPAN
>. This will
require very lax permissions in your Bugzilla directories.
Run it, instead, as a user with a name, set via your
httpd.conf file.
<DIV
CLASS="note"
><P
></P
><TABLE
CLASS="note"
WIDTH="100%"
BORDER="0"
><TR
><TD
WIDTH="25"
ALIGN="CENTER"
VALIGN="TOP"
><IMG
SRC="../images/note.gif"
HSPACE="5"
ALT="Note"></TD
><TD
ALIGN="LEFT"
VALIGN="TOP"
><P
> <SPAN
CLASS="QUOTE"
>"nobody"</SPAN
> is a real user on UNIX systems.
Having a process run as user id <SPAN
CLASS="QUOTE"
>"nobody"</SPAN
>
is absolutely no protection against system crackers
versus using any other user account. As a general
security measure, I recommend you create unique user
ID's for each daemon running on your system and, if
possible, use "chroot" to jail that process away from
the rest of your system.
</P
></TD
></TR
></TABLE
></DIV
>
</P
></LI
><LI
><P
> Ensure you have adequate access controls for the
$BUGZILLA_HOME/data/ and $BUGZILLA_HOME/shadow/
directories, as well as the $BUGZILLA_HOME/localconfig and
$BUGZILLA_HOME/globals.pl files. The localconfig file
stores your "bugs" user password, which would be terrible
to have in the hands of a criminal, while the "globals.pl"
stores some default information regarding your
installation which could aid a system cracker. In
addition, some files under $BUGZILLA_HOME/data/ store
sensitive information, and $BUGZILLA_HOME/shadow/ stores
bug information for faster retrieval. If you fail to
secure these directories and this file, you will expose
bug information to those who may not be allowed to see it.
</P
><DIV
CLASS="note"
><P
></P
><TABLE
CLASS="note"
WIDTH="100%"
BORDER="0"
><TR
><TD
WIDTH="25"
ALIGN="CENTER"
VALIGN="TOP"
><IMG
SRC="../images/note.gif"
HSPACE="5"
ALT="Note"></TD
><TD
ALIGN="LEFT"
VALIGN="TOP"
><P
> Bugzilla provides default .htaccess files to protect the
most common Apache installations. However, you should
verify these are adequate according to the site-wide
security policy of your web server, and ensure that the
.htaccess files are allowed to "override" default
permissions set in your Apache configuration files.
Covering Apache security is beyond the scope of this
Guide; please consult the Apache documentation for
details.
</P
><P
> If you are using a web server that does not support the
.htaccess control method, <EM
>you are at
risk!</EM
> After installing, check to see if
you can view the file "localconfig" in your web browser
(e.g.: <A
HREF="http://bugzilla.mozilla.org/localconfig"
TARGET="_top"
> http://bugzilla.mozilla.org/localconfig</A
>). If you can read the contents of this file, your web server has not secured your bugzilla directory properly and you must fix this problem before deploying Bugzilla. If, however, it gives you a "Forbidden" error, then it probably respects the .htaccess conventions and you are good to go.
</P
></TD
></TR
></TABLE
></DIV
><P
> When you run checksetup.pl, the script will attempt to modify various
permissions on files which Bugzilla uses. If you do not have a
webservergroup set in the localconfig file, then Bugzilla will have to
make certain files world readable and/or writable. <EM
>THIS IS
INSECURE!</EM
>. This means that anyone who can get access to
your system can do whatever they want to your Bugzilla installation.
</P
><DIV
CLASS="note"
><P
></P
><TABLE
CLASS="note"
WIDTH="100%"
BORDER="0"
><TR
><TD
WIDTH="25"
ALIGN="CENTER"
VALIGN="TOP"
><IMG
SRC="../images/note.gif"
HSPACE="5"
ALT="Note"></TD
><TD
ALIGN="LEFT"
VALIGN="TOP"
><P
> This also means that if your webserver runs all cgi scripts as the
same user/group, anyone on the system who can run cgi scripts will
be able to take control of your Bugzilla installation.
</P
></TD
></TR
></TABLE
></DIV
><P
> On Apache, you can use .htaccess files to protect access
CONTENT="Modular DocBook HTML Stylesheet Version 1.76b+
"><LINK
REL="HOME"
TITLE="The Bugzilla Guide"
HREF="index.html"><LINK
REL="UP"
TITLE="About This Guide"
HREF="about.html"><LINK
REL="PREVIOUS"
TITLE="Credits"
HREF="credits.html"><LINK
REL="NEXT"
TITLE="Document Conventions"
HREF="conventions.html"></HEAD
><BODY
CLASS="section"
BGCOLOR="#FFFFFF"
TEXT="#000000"
LINK="#0000FF"
VLINK="#840084"
ALINK="#0000FF"
><DIV
CLASS="NAVHEADER"
><TABLE
SUMMARY="Header navigation table"
WIDTH="100%"
BORDER="0"
CELLPADDING="0"
CELLSPACING="0"
><TR
><TH
COLSPAN="3"
ALIGN="center"
>The Bugzilla Guide</TH
></TR
><TR
><TD
WIDTH="10%"
ALIGN="left"
VALIGN="bottom"
><A
HREF="credits.html"
ACCESSKEY="P"
>Prev</A
></TD
><TD
WIDTH="80%"
ALIGN="center"
VALIGN="bottom"
>Chapter 1. About This Guide</TD
><TD
WIDTH="10%"
ALIGN="right"
VALIGN="bottom"
><A
HREF="conventions.html"
ACCESSKEY="N"
>Next</A
></TD
></TR
></TABLE
><HR
ALIGN="LEFT"
WIDTH="100%"></DIV
><DIV
CLASS="section"
><H1
CLASS="section"
><A
NAME="translations">1.6. Translations</H1
><P
> The Bugzilla Guide needs translators! Please volunteer your
translation into the language of your choice. If you will
translate this Guide, please notify the members of the
mozilla-webtools mailing list at
<TT
CLASS="email"
><<A
HREF="mailto:mozilla-webtools@mozilla.org"
>mozilla-webtools@mozilla.org</A
>></TT
>, and arrange with
The Bugzilla Team to check it into CVS.
</P
></DIV
><DIV
CLASS="NAVFOOTER"
><HR
ALIGN="LEFT"
WIDTH="100%"><TABLE
SUMMARY="Footer navigation table"
WIDTH="100%"
BORDER="0"
CELLPADDING="0"
CELLSPACING="0"
><TR
><TD
WIDTH="33%"
ALIGN="left"
VALIGN="top"
><A
HREF="credits.html"
ACCESSKEY="P"
>Prev</A
></TD
><TD
WIDTH="34%"
ALIGN="center"
VALIGN="top"
><A
HREF="index.html"
ACCESSKEY="H"
>Home</A
></TD
><TD
WIDTH="33%"
ALIGN="right"
VALIGN="top"
><A
HREF="conventions.html"
ACCESSKEY="N"
>Next</A
></TD
></TR
><TR
><TD
WIDTH="33%"
ALIGN="left"
VALIGN="top"
>Credits</TD
><TD
WIDTH="34%"
ALIGN="center"
VALIGN="top"
><A
HREF="about.html"
ACCESSKEY="U"
>Up</A
></TD
><TD
WIDTH="33%"
ALIGN="right"
VALIGN="top"
>Document Conventions</TD
></TR
></TABLE
></DIV
></BODY
></HTML
>
Some files were not shown because too many files have changed in this diff
Show More
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.