Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fixed a bug where the comments were correct but the code was wrong!

Browse Source 
the code needed to call p4 something like this
            'p4 changes -s submitted @2003/05/10,@now //...'
but instead called it like this
           'p4 changes -s @2003/05/10,@now //...'
the '-s' did not have any
argument which is required.  This bug was found by  Ken Beal .


git-svn-id: svn://10.0.0.236/trunk@153810 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
kestes%walrus.com
2004-03-10 03:42:44 +00:00
parent c6ba940999
commit ea313db392
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
mozilla/webtools/tinderbox2/src/lib/TinderDB/VC_Perforce.pm
View File

@@ -22,7 +22,7 @@
# The only perforce commands this module runs are:
#
# 'p4 describe -s $num'
# 'p4 changes -s \@$date_str\@now $filespec'
# 'p4 changes -s submitted \@$date_str\@now $filespec'
# which looks like this
@@ -75,8 +75,8 @@
# Contributor(s):
# $Revision: 1.20 $
# $Date: 2003-12-23 13:35:49 $
# $Revision: 1.21 $
# $Date: 2004-03-10 03:42:44 $
# $Author: kestes%walrus.com $
# $Source: /home/befator/cvs/jail/cvsroot/mozilla/webtools/tinderbox2/src/lib/TinderDB/VC_Perforce.pm,v $
# $Name: not supported by cvs2svn $
@@ -156,7 +156,7 @@ use Utils;
use VCDisplay;
$VERSION = ( qw $Revision: 1.20 $ )[1];
$VERSION = ( qw $Revision: 1.21 $ )[1];
@ISA = qw(TinderDB::BasicTxtDB);
@@ -910,7 +910,7 @@ sub get_new_change_sets {
$filespec = TreeData::Tree2Filespec($tree);
my (@cmd) = (
'p4', 'changes', '-s',
'p4', 'changes', '-s', 'submitted',
'@'.$date_str.',@now',
$filespec,
);